[Snyk] Upgrade com.google.guava:guava from 33.1.0-jre to 33.5.0-jre #4
Conversation
Snyk has created this PR to upgrade com.google.guava:guava from 33.1.0-jre to 33.5.0-jre. See this package in maven: com.google.guava:guava See this project in Snyk: https://app.snyk.io/org/asw/project/16cd4705-4031-4165-b643-9af4a21f2266?utm_source=github&utm_medium=referral&page=upgrade-pr
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @Dustin4444, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to update the project's Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, upgrades the Guava dependency from version 33.1.0-jre to 33.5.0-jre. While keeping dependencies updated is a good practice, I've identified a critical compatibility issue with the selected Guava artifact. The proposed version is not compatible with the project's target Java version. Please see my detailed comment in the pom.xml file for a suggested fix.
| <project.gson.version>2.8.6</project.gson.version> | ||
| <project.protobuf-java.version>3.25.3</project.protobuf-java.version> | ||
| <project.guava.version>33.1.0-jre</project.guava.version> | ||
| <project.guava.version>33.5.0-jre</project.guava.version> |
There was a problem hiding this comment.
The project is configured to target Java 7 (as seen in the maven-compiler-plugin configuration with <source>1.7</source> and <target>1.7</target>). However, the -jre artifacts of Guava versions after 20.0, including the proposed 33.5.0-jre, require Java 8 or higher. Using a -jre artifact in a Java 7 project can lead to NoSuchMethodError or other runtime errors if Java 8-specific APIs are invoked.
For Java 7 compatibility, Guava provides an -android artifact. The latest version that supports Android (and thus Java 7) is 33.2.1-android, as subsequent Guava versions have dropped Android support.
To ensure compatibility and prevent potential runtime issues, I recommend updating to the correct artifact and version.
| <project.guava.version>33.5.0-jre</project.guava.version> | |
| <project.guava.version>33.2.1-android</project.guava.version> |
2 participants
Snyk has created this PR to upgrade com.google.guava:guava from 33.1.0-jre to 33.5.0-jre.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 28 versions ahead of your current version.
The recommended version was released 4 months ago.
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: