[Snyk] Upgrade com.google.protobuf:protobuf-java from 3.25.3 to 4.33.2 #3
Conversation
Snyk has created this PR to upgrade com.google.protobuf:protobuf-java from 3.25.3 to 4.33.2. See this package in maven: com.google.protobuf:protobuf-java See this project in Snyk: https://app.snyk.io/org/asw/project/cd2f0592-ef4c-45c2-b187-06503ee4c9e4?utm_source=github&utm_medium=referral&page=upgrade-pr
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @Dustin4444, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, proposes upgrading com.google.protobuf:protobuf-java from 3.25.3 to 4.33.2. While dependency updates are generally good, this particular change introduces critical issues. The target version 4.33.2 does not seem to exist in public repositories. More importantly, this is a major version upgrade that requires Java 8, but the project is built with Java 7, which would break the build. Furthermore, the security vulnerability cited as the reason for this upgrade is already addressed by the current version 3.25.3. Therefore, I recommend rejecting this pull request.
| <project.jsr305.version>3.0.2</project.jsr305.version> | ||
| <project.gson.version>2.8.6</project.gson.version> | ||
| <project.protobuf-java.version>3.25.3</project.protobuf-java.version> | ||
| <project.protobuf-java.version>4.33.2</project.protobuf-java.version> |
There was a problem hiding this comment.
This upgrade to protobuf-java:4.33.2 is problematic for several reasons and will likely break the project build.
-
Java Version Incompatibility: The
protobuf-java4.x library requires Java 8 or higher. This project is currently configured to use Java 7, as seen from themaven-compiler-pluginconfiguration (<source>1.7</source>,<target>1.7</target>). Attempting to use this version will result in build failures. -
Non-existent Version: The version
4.33.2forcom.google.protobuf:protobuf-javadoes not appear to be available in public Maven repositories like Maven Central. This suggests there might be an error in the target version specified. -
Unnecessary for Vulnerability Fix: The pull request description states this upgrade is to fix vulnerability
SNYK-JAVA-COMGOOGLEPROTOBUF-8055227. However, according to Snyk's own vulnerability database, version3.25.3(the version currently in use) is a patched version and is not vulnerable. Therefore, this major upgrade seems unnecessary from a security perspective.
Given these critical issues, this pull request should not be merged in its current state. The dependency should remain at 3.25.3.
2 participants
Snyk has created this PR to upgrade com.google.protobuf:protobuf-java from 3.25.3 to 4.33.2.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 55 versions ahead of your current version.
The recommended version was released a month ago.
Issues fixed by the recommended upgrade:
SNYK-JAVA-COMGOOGLEPROTOBUF-8055227
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: