Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@
<project.datanucleus-maven-plugin.version>4.0.3</project.datanucleus-maven-plugin.version>
<project.servlet-api.version>2.5</project.servlet-api.version>
<!-- jakarta-servlet-api 5.0.0 is the last version that works with Java 8 -->
<project.jakarta-servlet-api.version>5.0.0</project.jakarta-servlet-api.version>
<project.jakarta-servlet-api.version>6.1.0</project.jakarta-servlet-api.version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade to jakarta.servlet-api:6.1.0 will break the build. Jakarta Servlet 6.x requires Java 11 or later, but this project targets Java 1.7 (as defined by the maven-compiler-plugin). The comment on line 547, <!-- jakarta-servlet-api 5.0.0 is the last version that works with Java 8 -->, highlights that the version is constrained by Java compatibility. This automated upgrade ignores this critical constraint and will cause compilation failures.

Suggested change
<project.jakarta-servlet-api.version>6.1.0</project.jakarta-servlet-api.version>
<project.jakarta-servlet-api.version>5.0.0</project.jakarta-servlet-api.version>

<deploy.autorelease>false</deploy.autorelease>
<gson.version>2.11.0</gson.version>
</properties>
Expand Down