Skip to content

[Snyk] Security upgrade urllib3 from 1.25.6 to 2.6.0 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dustin4444 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade urllib3 from 1.25.6 to 2.6.0 #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ pytest==5.2.1
pytest-cov==2.8.1
requests==2.22.0
six==1.12.0
urllib3==1.25.6
urllib3==2.6.0
Copy link

@gemini-code-assist gemini-code-assist bot Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade will break your project's dependencies for two reasons:

  1. Dependency Conflict: The requests package at version 2.22.0 (on line 16) requires urllib3<1.26. Upgrading urllib3 to a 2.x version is incompatible and will cause installation errors.
  2. Invalid Version: urllib3==2.6.0 is not a valid version on PyPI. The latest 2.x version is 2.0.7, and the latest 1.x version is 1.26.18.

To correctly fix the security vulnerabilities while maintaining a working set of dependencies, you should upgrade both requests and urllib3. A compatible and secure combination would be:

  • requests==2.31.0 (or newer)
  • urllib3==2.0.7 (or newer in the 2.x series)

Since this automated PR only modifies urllib3, it is incorrect. I recommend closing this PR and creating a new one that updates both packages.

wcwidth==0.1.7
zipp==0.6.0