Removing toLowerCase

shortstuffsushi · shortstuffsushi · commit 0ddee5fd22ab · 2013-03-12T20:18:09.000-05:00
Is there a reason all of the header fields are being lower cased? This actually caused requests I was making to a server I don't have control over to fail.
diff --git a/src/main/java/org/java_websocket/handshake/HandshakedataImpl1.java b/src/main/java/org/java_websocket/handshake/HandshakedataImpl1.java
@@ -32,7 +32,7 @@ public Iterator<String> iterateHttpFields() {
 
 	@Override
 	public String getFieldValue( String name ) {
-		String s = map.get( name.toLowerCase( Locale.ENGLISH ) );
+		String s = map.get( name );
 		if( s == null ) {
 			return "";
 		}
@@ -51,11 +51,11 @@ public void setContent( byte[] content ) {
 
 	@Override
 	public void put( String name, String value ) {
-		map.put( name.toLowerCase( Locale.ENGLISH ), value );
+		map.put( name, value );
 	}
 
 	@Override
 	public boolean hasFieldValue( String name ) {
-		return map.containsKey( name.toLowerCase( Locale.ENGLISH ) );
+		return map.containsKey( name );
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public Iterator<String> iterateHttpFields() {`
`32`	`32`
`33`	`33`	`@Override`
`34`	`34`	`public String getFieldValue( String name ) {`
`35`		`- String s = map.get( name.toLowerCase( Locale.ENGLISH ) );`
	`35`	`+ String s = map.get( name );`
`36`	`36`	`if( s == null ) {`
`37`	`37`	`return "";`
`38`	`38`	`}`
`@@ -51,11 +51,11 @@ public void setContent( byte[] content ) {`
`51`	`51`
`52`	`52`	`@Override`
`53`	`53`	`public void put( String name, String value ) {`
`54`		`- map.put( name.toLowerCase( Locale.ENGLISH ), value );`
	`54`	`+ map.put( name, value );`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`@Override`
`58`	`58`	`public boolean hasFieldValue( String name ) {`
`59`		`- return map.containsKey( name.toLowerCase( Locale.ENGLISH ) );`
	`59`	`+ return map.containsKey( name );`
`60`	`60`	`}`
`61`	`61`	`}`