This repository was archived by the owner on Mar 20, 2019. It is now read-only.
Fix to an incorrect call to IAuthorizationServerHost.GetClient #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Server would throw an unexpected exception when given an invalid HTTP header. Now correctly returns a 400 Bad Request.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two calls to IAuthorizationServerHost.GetClient had mutually exclusive requirements:
The problem prevented an OAuth2 Authorisation Server implementation from correctly handling an invalid ClientID - either the Authorize request would fail with a ProtocolException, or the Token request would fail with an ArgumentException.
This changes (2) to match the pattern of (1), which is also how the interface is documented.