Improve symbol provider#622
Merged
DonJayamanne merged 2 commits intoDonJayamanne:masterfrom Jan 16, 2017
patrys:improve-symbol-provider
Merged
Improve symbol provider#622DonJayamanne merged 2 commits intoDonJayamanne:masterfrom patrys:improve-symbol-provider
DonJayamanne merged 2 commits intoDonJayamanne:masterfrom
patrys:improve-symbol-provider
Conversation
DonJayamanne
reviewed
Jan 8, 2017
| } | ||
|
|
||
| public startKernel(kernelSpec: KernelspecMetadata, language: string): Promise<Kernel> { | ||
| public async startKernel(kernelSpec: KernelspecMetadata, language: string): Promise<Kernel> { |
Owner
There was a problem hiding this comment.
Sorry still away on holidays. I can see that you have also attempted to clean up some of the code by replacing promises with async, in totally unrelated code. Wouldn't it be better to introduce such clean up in a separate PR?
Contributor
Author
There was a problem hiding this comment.
It would! The thing is I started with changes to symbol provider but soon discovered that the test suite no longer passes even on master. I'll try to split my changes into two PRs.
Owner
There was a problem hiding this comment.
Yes, I need to fix some test issues, looks like the factoring isn't working anymore. Similar issues have Been reported by users too.
Contributor
Author
DonJayamanne
added a commit
that referenced
this pull request
Jan 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.