Skip to content

Fix/login redirect#4607

Open
Wormav wants to merge 2 commits into
Dokploy:canaryfrom
Wormav:fix/login-redirect
Open

Fix/login redirect#4607
Wormav wants to merge 2 commits into
Dokploy:canaryfrom
Wormav:fix/login-redirect

Conversation

@Wormav

@Wormav Wormav commented Jun 9, 2026

Copy link
Copy Markdown

What is this PR about?

This PR fixes the infinite loading spinner and redirection failure that occurs after a successful login (or invitation acceptance) on browsers like Safari and Firefox.

By awaiting the router.push("/dashboard/home") promise and removing the finally block that prematurely resets the loading state, we prevent React from re-rendering the component mid-flight. This ensures that the Next.js client-side navigation is not silently aborted.

Checklist

Before submitting this PR, please make sure that:

  • You created a dedicated branch based on the canary branch.
  • You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Issues related (if applicable)

closes #4220
closes #4479

Screenshots (if applicable)

(No UI changes, fixes navigation logic)

@Wormav Wormav requested a review from Siumauricio as a code owner June 9, 2026 21:04
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Login redirects to infinite loading — redirect: false response, no navigation after auth No automatic redirect to dashboard after login in Dokploy

1 participant