fix: use Redis 8 as the default image instead of Redis 7#4591
Open
ravindu0823 wants to merge 1 commit into
Open
fix: use Redis 8 as the default image instead of Redis 7#4591ravindu0823 wants to merge 1 commit into
ravindu0823 wants to merge 1 commit into
Conversation
The add-database dialog defined an inline dockerImageDefaultPlaceholder map whose redis value was redis:7. A blank create therefore sent redis:7 even though the server schema already defaults to redis 8, because the UI-provided value wins. Extract the default-image map into a pure, importable module (database-default-images.ts) and change the redis default to redis:8. add-database.tsx now imports the map, and the value is unit-tested. Fixes Dokploy#4172 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dosubot
Bot
added
the
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When adding a new database, leaving the Docker image blank for Redis created a container from
redis:7instead of Redis 8.Root cause
apps/dokploy/components/dashboard/project/add-database.tsxdefined an inlinedockerImageDefaultPlaceholdermap whoseredisvalue wasredis:7. On a blank create, this UI default is sent as thedockerImage, overriding the server schema (which already defaults to Redis 8). It also drove the input placeholder.Fix
apps/dokploy/components/dashboard/project/database-default-images.ts.redis:8(explicit colon-tag form, consistent with the other entries).add-database.tsxnow imports the map; both the default-used-on-create and the placeholder use the new value.Test
Added
apps/dokploy/__test__/utils/database-default-images.test.tsasserting the redis default isredis:8.Typecheck (
pnpm --filter=dokploy run typecheck) is clean.Fixes #4172
🤖 Generated with Claude Code