fix: restart service after a failed volume backup with "Turn Off Container" enabled#4587
Open
ravindu0823 wants to merge 1 commit into
Open
fix: restart service after a failed volume backup with "Turn Off Container" enabled#4587ravindu0823 wants to merge 1 commit into
ravindu0823 wants to merge 1 commit into
Conversation
…ainer" enabled When "Turn Off Container During Backup" is enabled, the service is scaled to 0 (or the container stopped) before the backup runs. If the backup step then failed — e.g. Docker could not pull the ubuntu image used for the tar — the script aborted via `set -e` before the start/scale-up step, leaving the service offline indefinitely until a manual reload. Run the backup in a standalone subshell with `set +e` in the parent, capture its exit status, and always run the start step afterwards. The job still reports failure (and fires notifications) once the service is back up, and the S3 upload only runs on success. The subshell is deliberately NOT the left side of `|| BACKUP_EXIT=$?`: in that tested context bash disables the subshell's own `set -e`, which would silently swallow a mid-backup failure and report success. A plain subshell followed by `$?` keeps `set -e` active inside it. Applies to both application and compose (stack and docker-compose) volume backups via a shared guard. Fixes Dokploy#4263 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@-