fix: exact ep square handling #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
is this pr not ready? |
Disservin
force-pushed
the
exact-ep-handling
branch
from
5005c97 to
cd5fb75
Compare
Contributor
|
It seems cutechess has went ahead and implemented this cutechess/cutechess@b57c702 |
Owner
Author
|
@ArcheCadia, @gahtan-syarif I am still a bit unsure about this.. fastchess/app/src/matchmaking/match/match.cpp Line 497 in 680feb0 also taking the 3fold repetition into account with the change fastchess will notice (correctly) that the game already ended, most engines do not implement this correctly and as such will get illegal pv warnings after this merge.. I guess it is technically correct, just thinking about the consequences of this.. does Stockfish do this even correctly or should we skip the repetition check for the pv line? |
Disservin
force-pushed
the
exact-ep-handling
branch
from
ee9998d to
5d19da0
Compare
Contributor
|
Personally i think its a good idea to let engine authors know through the illegal pv warning. Its an edge case thats not taken into account in a lot of engines because they are not aware... so by doing this it will give them a heads up to implement correct ep square handling on pinned positions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the issue where
is correctly adjudicated as a threefold repetition.