fix GC thread crash in WimFileSystem dispose#263
Open
svenclaesson wants to merge 1 commit intoDiscUtils:developfrom
Open
fix GC thread crash in WimFileSystem dispose#263svenclaesson wants to merge 1 commit intoDiscUtils:developfrom
svenclaesson wants to merge 1 commit intoDiscUtils:developfrom
Conversation
Author
|
@LordMike please consider this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this code in constructor of WimFileSystem throws
_metaDataStream is never set
Later the GC will call the deconstructor in
DiscFileSystemDispose(false)that will throw when _metaDataStream is not setThis is a major problem for us when trying to work with a corrupt wim-image.