Revert "Found sad disposal transaction in async execution. :( This seems to be impossible."

7k8m · 7k8m · commit dff28025273e · 2020-03-07T11:45:56.000+09:00
This reverts commit 16545fd.
diff --git a/DirectSQL/Database.cs b/DirectSQL/Database.cs
@@ -387,6 +387,32 @@ public static void Transaction(
             }
         }
 
+        /// <summary>
+        /// Execute in a transaction asynchronously.
+        /// </summary>
+        /// <param name="connection">connection to be used</param>
+        /// <param name="execute">to be executed</param>
+        /// <returns>A task stands for asynchronous execution</returns>
+        public static async Task TransactionAsync(
+            C connection, 
+            AsyncSqlExecution<C,T> execute)
+        {
+            using (var transaction = (T) connection.BeginTransaction())
+            {
+                try
+                {
+                    await execute(connection, transaction);
+                }
+                catch (Exception exception)
+                {
+                    transaction.Rollback();
+                    throw new DatabaseException(
+                        MessageResource.msg_error_sqlExecutionError, 
+                        exception);
+                }
+            }
+        }
+
         private static(String sql, (String,Object)[] parameters) ExtractSqlAndParam(FormattableString sqlFormattableString)
         {
             var paramNames =
diff --git a/TestSqlLiteDatabase/TransactionTest.cs b/TestSqlLiteDatabase/TransactionTest.cs
@@ -48,6 +48,43 @@ public void TestTransaction()
             });
         }
 
+        [TestMethod]
+        public void TestTransactionAsync()
+        {
+            SqlLiteDatabase db = new SqlLiteDatabase("Data Source=:memory:");
+
+            db.Process(async (connection) => {
+                CreateTableForTest(connection);
+
+                await SqlLiteDatabase.TransactionAsync(connection,
+                    async (conn, tran) => {
+                        await Task.Delay(1);
+                        InsertDataForTest(conn, tran);
+                        tran.Rollback();
+                    }
+                );
+
+                await SqlLiteDatabase.TransactionAsync(connection,
+                    async (conn, tran) =>
+                    {
+                        await Task.Delay(1);
+                        AssertDataCount(0, conn, tran);
+                        InsertDataForTest(conn, tran);
+                        AssertDataCount(1, conn, tran);
+                        tran.Commit();
+                    }
+                );
+
+                await SqlLiteDatabase.TransactionAsync(connection,
+                    async (conn, tran) =>
+                    {
+                        await Task.Delay(1);
+                        AssertDataCount(1, conn, tran);
+                    }
+                );
+            });
+        }
+
         private static void AssertDataCount(long expectedCount,SQLiteConnection conn, SQLiteTransaction tran)
         {
             Assert.AreEqual(
