Skip to content

Remove unecessary code#93

Open
Sami32 wants to merge 3 commits into
masterfrom
Cleaning1
Open

Remove unecessary code#93
Sami32 wants to merge 3 commits into
masterfrom
Cleaning1

Conversation

@Sami32
Copy link
Copy Markdown
Contributor

@Sami32 Sami32 commented Sep 29, 2018 •
edited by Nadahar
Loading

This change is Reviewable

@Sami32
ssbj
a22869a 
Signed-off-by: Sami32 <Sami32@users.noreply.github.com>
@Sami32 Sami32 changed the title Remove unecessary transcoding code Remove unecessary code Sep 29, 2018
@Sami32
Copy link
Copy Markdown
Contributor Author

Sami32 commented Oct 1, 2018 •
edited
Loading

Note:
All the code related to TranscodeAudioTo441kHz should also be removed later when the MIME Types PR will be merged, as all these sync / pitch issues that this workaround is used for are only related to incorrect MIME Types and missing DLNA implementation.

@Sami32
Copy link
Copy Markdown
Contributor Author

Sami32 commented Oct 1, 2018

No wonder why:

http-get::audio/L16;rate=44100;channels=1:DLNA.ORG_PN=LPCM
http-get::audio/L16;rate=44100;channels=2:DLNA.ORG_PN=LPCM

@Sami32
Copy link
Copy Markdown
Contributor Author

Sami32 commented Oct 1, 2018

The 3 others poor renderers still using this parameter are not using MediaInfo that explain why they added this option from old time.
When they will be enhanced and use MediaInfo parsing the TranscodeAudioTo441kHz code could be totally removed.

@Sami32
Copy link
Copy Markdown
Contributor Author

Sami32 commented Oct 2, 2018

Or like the http-get:*:audio/L16:DLNA.ORG_PN=LPCM_low DLNA profile

@Sami32 Sami32 mentioned this pull request Oct 3, 2018
Merged
@Nadahar Nadahar added this to the Future milestone Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Not Ready

Projects

None yet

Milestone

Future

Development

Successfully merging this pull request may close these issues.

2 participants

@Sami32 @Nadahar