Remove SIMD vectors by Przemog1 · Pull Request #837 · Devsh-Graphics-Programming/Nabla

Przemog1 · 2025-02-18T16:33:00Z

No description provided.

…s - we were never be able to do ourMatrixT = glmMatrixT and its important since a lot of utils create glmMatrixT actually

…atrix xD remove the = operator glm -> to ours

…ls.hlsl from #760

…H (ambiguity dependent type issues), reference #760

…ng/Nabla/pull/760/files#r1816728485 for #760 PR, update examples_tests submodule

…odule

…g/Nabla into rm_core_mat_vec

devshgraphicsprogramming · 2025-02-20T10:57:19Z

include/ICameraSceneNode.h

 		The function will figure it out if you've set an orthogonal matrix.
 		\param projection The new projection matrix of the camera.
 		*/
-		virtual void setProjectionMatrix(const core::matrix4SIMD& projection) =0;
+		virtual void setProjectionMatrix(const hlsl::float32_t4x4& projection) =0;

 		//! Gets the current projection matrix of the camera.
 		/** \return The current projection matrix of the camera. */
-		inline const core::matrix4SIMD& getProjectionMatrix() const { return projMatrix; }
+		inline const hlsl::float32_t4x4& getProjectionMatrix() const { return projMatrix; }

 		//! Gets the current view matrix of the camera.
 		/** \return The current view matrix of the camera. */
-		virtual const core::matrix3x4SIMD& getViewMatrix() const =0;
+		virtual const hlsl::float32_t3x4& getViewMatrix() const =0;

-		virtual const core::matrix4SIMD& getConcatenatedMatrix() const =0;
+		virtual const hlsl::float32_t4x4& getConcatenatedMatrix() const =0;
 #if 0
 		//! It is possible to send mouse and key events to the camera.
 		/** Most cameras may ignore this input, but camera scene nodes


nuke the whole file

devshgraphicsprogramming · 2025-02-20T10:57:32Z

include/SColor.h

 	stores the color values in a single 32 bit integer.
 	*/
-	class SColorf : private core::vectorSIMDf
+	class SColorf : private hlsl::float32_t4
 	{
 	public:
 		//! Default constructor for SColorf.
 		/** Sets red, green and blue to 0.0f and alpha to 1.0f. */
-		SColorf() : vectorSIMDf(0.f,0.f,0.f,1.f) {}
+		SColorf() : hlsl::float32_t4(0.f,0.f,0.f,1.f) {}

 		//! Constructs a color from up to four color values: red, green, blue, and alpha.
 		/** \param r: Red color component. Should be a value between


can we nuke the file?

devshgraphicsprogramming · 2025-02-20T10:58:03Z

include/line3d.h

 #ifndef __NBL_LINE_3D_H_INCLUDED__
 #define __NBL_LINE_3D_H_INCLUDED__

-#include "vectorSIMD.h"
+#include <vector3d.h>

 namespace nbl
 {


do we use this file at all?

devshgraphicsprogramming · 2025-02-20T11:00:01Z

include/nbl/asset/IImage.h

-			static inline uint64_t		getLocalByteOffset(const core::vector3du32_SIMD& localXYZLayerOffset, const core::vector3du32_SIMD& byteStrides)
+			static inline uint64_t		getLocalByteOffset(const hlsl::uint32_t3& localXYZLayerOffset, const hlsl::uint32_t3& byteStrides)
 			{
-				return core::dot(localXYZLayerOffset,byteStrides)[0];
+				return hlsl::dot(localXYZLayerOffset,byteStrides);
 			}
-			inline uint64_t				getByteOffset(const core::vector3du32_SIMD& localXYZLayerOffset, const core::vector3du32_SIMD& byteStrides) const
+			inline uint64_t				getByteOffset(const hlsl::uint32_t3& localXYZLayerOffset, const hlsl::uint32_t3& byteStrides) const


check if this vector is not supposed to be 4D (xyz + layer) so uint32_t4 instead

devshgraphicsprogramming · 2025-02-20T11:01:00Z

include/nbl/asset/IImage.h

-				auto minPt = core::vector3du32_SIMD(off.x,off.y,off.z);
+				auto minPt = hlsl::uint32_t3(off.x,off.y,off.z);
 				auto srcBlockDims = asset::getBlockDimensions(srcImage->getCreationParameters().format);
 				if (((minPt%srcBlockDims)!=zero).any())


.any() is not a method of HLSL/GLM vector

whenever you change a templated function, you need to instantiate it to check it still compiles (or better, add a unit test to some example)

src/nbl/video/utilities/ImageRegionIterator.cpp

devshgraphicsprogramming · 2025-02-21T09:00:42Z

include/nbl/asset/format/EFormat.h

-        return core::vector4du32_SIMD(4u, 4u, 1u, 1u);
+        return hlsl::uint32_t4(4u, 4u, 1u, 1u);
    case EF_ASTC_5x4_UNORM_BLOCK:
    case EF_ASTC_5x4_SRGB_BLOCK:
-        return core::vector4du32_SIMD(5u, 4u, 1u, 1u);
+        return hlsl::uint32_t4(5u, 4u, 1u, 1u);
    case EF_ASTC_5x5_UNORM_BLOCK:
    case EF_ASTC_5x5_SRGB_BLOCK:
-        return core::vector4du32_SIMD(5u, 5u, 1u, 1u);
+        return hlsl::uint32_t4(5u, 5u, 1u, 1u);
    case EF_ASTC_6x5_UNORM_BLOCK:
    case EF_ASTC_6x5_SRGB_BLOCK:
-        return core::vector4du32_SIMD(6u, 5u, 1u, 1u);
+        return hlsl::uint32_t4(6u, 5u, 1u, 1u);
    case EF_ASTC_6x6_UNORM_BLOCK:
    case EF_ASTC_6x6_SRGB_BLOCK:
-        return core::vector4du32_SIMD(6u, 6u, 1u, 1u);
+        return hlsl::uint32_t4(6u, 6u, 1u, 1u);
    case EF_ASTC_8x5_UNORM_BLOCK:
    case EF_ASTC_8x5_SRGB_BLOCK:
-        return core::vector4du32_SIMD(8u, 5u, 1u, 1u);
+        return hlsl::uint32_t4(8u, 5u, 1u, 1u);
    case EF_ASTC_8x6_UNORM_BLOCK:
    case EF_ASTC_8x6_SRGB_BLOCK:
-        return core::vector4du32_SIMD(8u, 6u, 1u, 1u);
+        return hlsl::uint32_t4(8u, 6u, 1u, 1u);
    case EF_ASTC_8x8_UNORM_BLOCK:
    case EF_ASTC_8x8_SRGB_BLOCK:
-        return core::vector4du32_SIMD(8u, 8u, 1u, 1u);
+        return hlsl::uint32_t4(8u, 8u, 1u, 1u);
    case EF_ASTC_10x5_UNORM_BLOCK:
    case EF_ASTC_10x5_SRGB_BLOCK:
-        return core::vector4du32_SIMD(10u, 5u, 1u, 1u);
+        return hlsl::uint32_t4(10u, 5u, 1u, 1u);
    case EF_ASTC_10x6_UNORM_BLOCK:
    case EF_ASTC_10x6_SRGB_BLOCK:
-        return core::vector4du32_SIMD(10u, 6u, 1u, 1u);
+        return hlsl::uint32_t4(10u, 6u, 1u, 1u);
    case EF_ASTC_10x8_UNORM_BLOCK:
    case EF_ASTC_10x8_SRGB_BLOCK:
-        return core::vector4du32_SIMD(10u, 8u, 1u, 1u);
+        return hlsl::uint32_t4(10u, 8u, 1u, 1u);
    case EF_ASTC_10x10_UNORM_BLOCK:
    case EF_ASTC_10x10_SRGB_BLOCK:
-        return core::vector4du32_SIMD(10u, 10u, 1u, 1u);
+        return hlsl::uint32_t4(10u, 10u, 1u, 1u);
    case EF_ASTC_12x10_UNORM_BLOCK:
    case EF_ASTC_12x10_SRGB_BLOCK:
-        return core::vector4du32_SIMD(12u, 10u, 1u, 1u);
+        return hlsl::uint32_t4(12u, 10u, 1u, 1u);
    case EF_ASTC_12x12_UNORM_BLOCK:
    case EF_ASTC_12x12_SRGB_BLOCK:
-        return core::vector4du32_SIMD(12u, 12u, 1u, 1u);
+        return hlsl::uint32_t4(12u, 12u, 1u, 1u);
    case EF_PVRTC1_2BPP_UNORM_BLOCK_IMG:
    case EF_PVRTC2_2BPP_SRGB_BLOCK_IMG:
    case EF_PVRTC2_2BPP_UNORM_BLOCK_IMG:
    case EF_PVRTC1_2BPP_SRGB_BLOCK_IMG:
-        return core::vector4du32_SIMD(8u, 4u, 1u, 1u);
+        return hlsl::uint32_t4(8u, 4u, 1u, 1u);
    case EF_PVRTC1_4BPP_UNORM_BLOCK_IMG:
    case EF_PVRTC2_4BPP_UNORM_BLOCK_IMG:
    case EF_PVRTC1_4BPP_SRGB_BLOCK_IMG:
    case EF_PVRTC2_4BPP_SRGB_BLOCK_IMG:
-        return core::vector4du32_SIMD(4u, 4u, 1u, 1u);
+        return hlsl::uint32_t4(4u, 4u, 1u, 1u);
    default:
-        return core::vector4du32_SIMD(1u);
+        return hlsl::uint32_t4(1u);


uint32_t3 same as the return type, cut off the last coord w=1

devshgraphicsprogramming · 2025-02-21T09:00:59Z

include/nbl/asset/format/EFormat.h

-        return core::vector4du32_SIMD(4u, 4u, 1u, 1u);
+        return hlsl::uint32_t4(4u, 4u, 1u, 1u);
    case EF_ASTC_5x4_UNORM_BLOCK:
    case EF_ASTC_5x4_SRGB_BLOCK:
-        return core::vector4du32_SIMD(5u, 4u, 1u, 1u);
+        return hlsl::uint32_t4(5u, 4u, 1u, 1u);
    case EF_ASTC_5x5_UNORM_BLOCK:
    case EF_ASTC_5x5_SRGB_BLOCK:
-        return core::vector4du32_SIMD(5u, 5u, 1u, 1u);
+        return hlsl::uint32_t4(5u, 5u, 1u, 1u);
    case EF_ASTC_6x5_UNORM_BLOCK:
    case EF_ASTC_6x5_SRGB_BLOCK:
-        return core::vector4du32_SIMD(6u, 5u, 1u, 1u);
+        return hlsl::uint32_t4(6u, 5u, 1u, 1u);
    case EF_ASTC_6x6_UNORM_BLOCK:
    case EF_ASTC_6x6_SRGB_BLOCK:
-        return core::vector4du32_SIMD(6u, 6u, 1u, 1u);
+        return hlsl::uint32_t4(6u, 6u, 1u, 1u);
    case EF_ASTC_8x5_UNORM_BLOCK:
    case EF_ASTC_8x5_SRGB_BLOCK:
-        return core::vector4du32_SIMD(8u, 5u, 1u, 1u);
+        return hlsl::uint32_t4(8u, 5u, 1u, 1u);
    case EF_ASTC_8x6_UNORM_BLOCK:
    case EF_ASTC_8x6_SRGB_BLOCK:
-        return core::vector4du32_SIMD(8u, 6u, 1u, 1u);
+        return hlsl::uint32_t4(8u, 6u, 1u, 1u);
    case EF_ASTC_8x8_UNORM_BLOCK:
    case EF_ASTC_8x8_SRGB_BLOCK:
-        return core::vector4du32_SIMD(8u, 8u, 1u, 1u);
+        return hlsl::uint32_t4(8u, 8u, 1u, 1u);
    case EF_ASTC_10x5_UNORM_BLOCK:
    case EF_ASTC_10x5_SRGB_BLOCK:
-        return core::vector4du32_SIMD(10u, 5u, 1u, 1u);
+        return hlsl::uint32_t4(10u, 5u, 1u, 1u);
    case EF_ASTC_10x6_UNORM_BLOCK:
    case EF_ASTC_10x6_SRGB_BLOCK:
-        return core::vector4du32_SIMD(10u, 6u, 1u, 1u);
+        return hlsl::uint32_t4(10u, 6u, 1u, 1u);
    case EF_ASTC_10x8_UNORM_BLOCK:
    case EF_ASTC_10x8_SRGB_BLOCK:
-        return core::vector4du32_SIMD(10u, 8u, 1u, 1u);
+        return hlsl::uint32_t4(10u, 8u, 1u, 1u);
    case EF_ASTC_10x10_UNORM_BLOCK:
    case EF_ASTC_10x10_SRGB_BLOCK:
-        return core::vector4du32_SIMD(10u, 10u, 1u, 1u);
+        return hlsl::uint32_t4(10u, 10u, 1u, 1u);
    case EF_ASTC_12x10_UNORM_BLOCK:
    case EF_ASTC_12x10_SRGB_BLOCK:
-        return core::vector4du32_SIMD(12u, 10u, 1u, 1u);
+        return hlsl::uint32_t4(12u, 10u, 1u, 1u);
    case EF_ASTC_12x12_UNORM_BLOCK:
    case EF_ASTC_12x12_SRGB_BLOCK:
-        return core::vector4du32_SIMD(12u, 12u, 1u, 1u);
+        return hlsl::uint32_t4(12u, 12u, 1u, 1u);
    case EF_PVRTC1_2BPP_UNORM_BLOCK_IMG:
    case EF_PVRTC2_2BPP_SRGB_BLOCK_IMG:
    case EF_PVRTC2_2BPP_UNORM_BLOCK_IMG:
    case EF_PVRTC1_2BPP_SRGB_BLOCK_IMG:
-        return core::vector4du32_SIMD(8u, 4u, 1u, 1u);
+        return hlsl::uint32_t4(8u, 4u, 1u, 1u);
    case EF_PVRTC1_4BPP_UNORM_BLOCK_IMG:
    case EF_PVRTC2_4BPP_UNORM_BLOCK_IMG:
    case EF_PVRTC1_4BPP_SRGB_BLOCK_IMG:
    case EF_PVRTC2_4BPP_SRGB_BLOCK_IMG:
-        return core::vector4du32_SIMD(4u, 4u, 1u, 1u);
+        return hlsl::uint32_t4(4u, 4u, 1u, 1u);
    default:
-        return core::vector4du32_SIMD(1u);
+        return hlsl::uint32_t4(1u);


same as https://github.com/Devsh-Graphics-Programming/Nabla/pull/837/files#r1965115175

devshgraphicsprogramming · 2025-02-21T09:03:23Z

include/nbl/asset/metadata/CMTLMetadata.h

-                    core::vector3df_SIMD ambient = core::vector3df_SIMD(1.f);
+                    hlsl::float32_t4 ambient = hlsl::float32_t4(1.f);
                    //Kd
-                    core::vector3df_SIMD diffuse = core::vector3df_SIMD(1.f);
+                    hlsl::float32_t4 diffuse = hlsl::float32_t4(1.f);
                    //Ks
-                    core::vector3df_SIMD specular = core::vector3df_SIMD(1.f);
+                    hlsl::float32_t4 specular = hlsl::float32_t4(1.f);
                    //Ke
-                    core::vector3df_SIMD emissive = core::vector3df_SIMD(1.f);
+                    hlsl::float32_t4 emissive = hlsl::float32_t4(1.f);
                    //Tf
-                    core::vector3df_SIMD transmissionFilter = core::vector3df_SIMD(1.f);
+                    hlsl::float32_t4 transmissionFilter = hlsl::float32_t4(1.f);


use float32_t3 and adjust the static assert at the end

devshgraphicsprogramming · 2025-02-26T18:58:10Z

btw can you edit the descriptor and let me know if the #760 PR is supposed to be merged/done first or this is an UBER PR which removes old vectors and matrices all at once?

Przemog1 and others added 30 commits October 21, 2024 13:14

Saving work

da88575

Removed SIMD matrix classes

ab77ca4

add operator= for glm:: matrices corresponding to our at home matrice…

cdf867d

…s - we were never be able to do ourMatrixT = glmMatrixT and its important since a lot of utils create glmMatrixT actually

I'm stupid, I have explicit at home matrix constructor taking glm:: m…

6ef4f89

…atrix xD remove the = operator glm -> to ours

steal include/nbl/builtin/hlsl/matrix_utils/transformation_matrix_uti…

22f505c

…ls.hlsl from #760

fix getMatrix3x4As4x4 (return type issues) & buildCameraLookAtMatrixR…

51f4ced

…H (ambiguity dependent type issues), reference #760

Saving work

1397756

update examples_tests submodule

7f2c085

actually *this* addresses https://github.com/Devsh-Graphics-Programmi…

f1daa25

…ng/Nabla/pull/760/files#r1816728485 for #760 PR, update examples_tests submodule

update examples_tests submodule

2192e99

Saving work

bc8b2a4

update examples_tests submodule

520b1f5

Saving work

fda286a

Removed core::matrixSIMD

6f9f099

Resolved conflicts, merged master

91bbb85

Fixed length function

339ec8e

Refactor

bfdbdbc

Refactor

f00262d

Resolved conflicts, merged cameraz

537cd24

forgot to commit projection build methods, update examples_tests subm…

a0890f0

…odule

add is_smart_refctd_ptr_v, update examples_tests submodule

0109b22

update examples_tests submodule

2a29a2f

update examples_tests submodule

7673769

pull master & resolve conflicts

fc7bc33

Merge branch 'master' of https://github.com/Devsh-Graphics-Programmin…

55672c7

…g/Nabla into rm_core_mat_vec

Resolved conflicts, merged cameraz

3372760

Updated examples_tests

3fee9c1

Refactor

9746e6a

Updated examples

d6c9716

Resolved conflicts, merged master

b830b94

Przemog1 added 13 commits November 13, 2024 15:06

Saving work

cfc8dc9

Resolved conflicts, merged master

5585e52

Identity matrices refactor

22630d0

Fixed templated functions

2617c16

Resolved conflicts, merged master

4a894fe

Resolved conflicts, merged new_tgmath

de00c73

Removed vectorSIMDf.h

25fd733

Saving work

214ba69

Saving work

93886eb

Saving work

8bc358a

Implemented plane.hlsl

c25c647

Resolved conflicts, merged new_planes

77586a4

Removed SIMD vectors

8c07baa

devshgraphicsprogramming reviewed Feb 20, 2025

View reviewed changes

src/nbl/video/utilities/ImageRegionIterator.cpp Show resolved Hide resolved

devshgraphicsprogramming reviewed Feb 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove SIMD vectors#837

Remove SIMD vectors#837
Przemog1 wants to merge 43 commits intomasterfrom
rm_core_vector

Przemog1 commented Feb 18, 2025

Uh oh!

devshgraphicsprogramming Feb 20, 2025

Uh oh!

devshgraphicsprogramming Feb 20, 2025

Uh oh!

devshgraphicsprogramming Feb 20, 2025

Uh oh!

devshgraphicsprogramming Feb 20, 2025

Uh oh!

devshgraphicsprogramming Feb 20, 2025

Uh oh!

devshgraphicsprogramming Feb 20, 2025

Uh oh!

Uh oh!

devshgraphicsprogramming Feb 21, 2025

Uh oh!

devshgraphicsprogramming Feb 21, 2025

Uh oh!

devshgraphicsprogramming Feb 21, 2025

Uh oh!

devshgraphicsprogramming commented Feb 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Przemog1 commented Feb 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devshgraphicsprogramming commented Feb 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants