Fix sybrenstuvel#173: unpickling doesn't restore full object

busunkim96 · sybrenstuvel · commit eb6ddb6e3ec5 · 2021-02-24T11:32:07.000+01:00
When a `PrivateKey` or `PublicKey` is unpickled `AbstractKey.__init__()`
should be called so `self.mutex` and `self.blindfac` are created.
diff --git a/rsa/key.py b/rsa/key.py
@@ -251,6 +251,7 @@ def __getstate__(self) -> typing.Tuple[int, int]:
     def __setstate__(self, state: typing.Tuple[int, int]) -> None:
         """Sets the key from tuple."""
         self.n, self.e = state
+        AbstractKey.__init__(self, self.n, self.e)
 
     def __eq__(self, other: typing.Any) -> bool:
         if other is None:
@@ -426,6 +427,7 @@ def __getstate__(self) -> typing.Tuple[int, int, int, int, int, int, int, int]:
     def __setstate__(self, state: typing.Tuple[int, int, int, int, int, int, int, int]) -> None:
         """Sets the key from tuple."""
         self.n, self.e, self.d, self.p, self.q, self.exp1, self.exp2, self.coef = state
+        AbstractKey.__init__(self, self.n, self.e)
 
     def __eq__(self, other: typing.Any) -> bool:
         if other is None:
diff --git a/tests/test_load_save_keys.py b/tests/test_load_save_keys.py
@@ -203,10 +203,15 @@ def test_private_key(self):
         unpickled = pickle.loads(pickled)
         self.assertEqual(pk, unpickled)
 
+        for attr in rsa.key.AbstractKey.__slots__:
+            self.assertTrue(hasattr(unpickled, attr))
+
     def test_public_key(self):
         pk = rsa.key.PublicKey(3727264081, 65537)
 
         pickled = pickle.dumps(pk)
         unpickled = pickle.loads(pickled)
 
         self.assertEqual(pk, unpickled)
+        for attr in rsa.key.AbstractKey.__slots__:
+            self.assertTrue(hasattr(unpickled, attr))
