Ensure we get a float value.

brian-brazil · brian-brazil · commit 8d3795e4b5c2 · 2015-06-21T12:29:03.000+01:00
diff --git a/prometheus_client/__init__.py b/prometheus_client/__init__.py
@@ -370,7 +370,7 @@ def _floatToGoString(d):
     elif d == _MINUS_INF:
         return '-Inf'
     else:
-        return repr(d)
+        return repr(float(d))
 
 
 @_MetricWrapper
diff --git a/tests/test_client.py b/tests/test_client.py
@@ -3,7 +3,7 @@
 import unittest
 
 
-from prometheus_client import Gauge, Counter, Summary, Histogram
+from prometheus_client import Gauge, Counter, Summary, Histogram, Metric
 from prometheus_client import CollectorRegistry, generate_latest, ProcessCollector
 
 
@@ -304,6 +304,20 @@ def test_escaping(self):
         c.labels('\\x\n"').inc(1)
         self.assertEqual(b'# HELP cc A\\ncount\\\\er\n# TYPE cc counter\ncc{a="\\\\x\\n\\""} 1.0\n', generate_latest(self.registry))
 
+    def test_nonnumber(self):
+        class MyNumber():
+            def __repr__(self):
+              return "MyNumber(123)"
+            def __float__(self):
+              return 123.0
+        class MyCollector():
+            def collect(self):
+                metric = Metric("nonnumber", "Non number", 'untyped')
+                metric.add_sample("nonnumber", {}, MyNumber())
+                yield metric
+        self.registry.register(MyCollector())
+        self.assertEqual(b'# HELP nonnumber Non number\n# TYPE nonnumber untyped\nnonnumber 123.0\n', generate_latest(self.registry))
+
 
 class TestProcessCollector(unittest.TestCase):
     def setUp(self):
