DataGrid: unskip e2e functional editing tests#32412
Open
anna-shakhova wants to merge 1 commit intoDevExpress:26_1from
Open
DataGrid: unskip e2e functional editing tests#32412anna-shakhova wants to merge 1 commit intoDevExpress:26_1from
anna-shakhova wants to merge 1 commit intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the DataGrid editing tests by splitting a large, complex test file into two smaller, more focused test files and adds a new helper method to the CommandCell model.
Changes:
- Removed the monolithic
editing_matrix.tsfile (451 lines) that contained all tests marked as unstable - Created two new focused test files:
editing.functional_matrix.tsfor editing existing cells andeditingNewRow.functional_matrix.tsfor adding new rows - Added
getEditButton()method to the CommandCell TestCafe model for more semantic button access - Tests are now properly "unskipped" - removed
test.meta({ unstable: true })from all tests
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/testcafe-models/dataGrid/commandCell.ts | Added getEditButton() helper method with corresponding CSS class constant for more semantic access to edit buttons |
| e2e/testcafe-devextreme/tests/dataGrid/common/editing_matrix.ts | Removed large monolithic test file with 451 lines containing unstable tests |
| e2e/testcafe-devextreme/tests/dataGrid/common/editing/editingNewRow.functional_matrix.ts | New focused test file for adding new rows across different editing modes (cell, batch, row, form, popup) |
| e2e/testcafe-devextreme/tests/dataGrid/common/editing/editing.functional_matrix.ts | New comprehensive test file for editing existing cells with various configurations (keyboard/mouse, masked/unmasked inputs) |
e2e/testcafe-devextreme/tests/dataGrid/common/editing/editingNewRow.functional_matrix.ts
Show resolved
Hide resolved
e2e/testcafe-devextreme/tests/dataGrid/common/editing/editing.functional_matrix.ts
Outdated
Show resolved
Hide resolved
anna-shakhova
force-pushed
the
26_1__fix_editing_tests
branch
from
77a248b to
294cd8b
Compare
anna-shakhova
force-pushed
the
26_1__fix_editing_tests
branch
from
294cd8b to
d771e22
Compare
e2e/testcafe-devextreme/tests/dataGrid/common/editing/editing.functional_matrix.ts
Outdated
Show resolved
Hide resolved
anna-shakhova
force-pushed
the
26_1__fix_editing_tests
branch
from
d771e22 to
d41f8e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.