WIP: TreeList ColumnButtonClickEvent#32404
WIP: TreeList ColumnButtonClickEvent#32404mpreyskurantov wants to merge 2 commits intoDevExpress:26_1from
Conversation
…lickEvent type in onClick prop
…-angular/src/ui/nested/base/text-editor-button-dxi.ts via single rule, ref DevExpress#25395
There was a problem hiding this comment.
Pull request overview
Adds a dedicated ColumnButtonClickEvent API surface for TreeList column-button clicks and propagates that type through generated typings and wrappers to match DataGrid’s existing pattern.
Changes:
- Documents
ColumnButtonClickEventin TreeList typings and addsrow/columnmember doc links. - Updates TreeList column button
onClickcallback typing to useColumnButtonClickEventacross core typings and React/Vue/Angular wrappers. - Removes the incorrect
onClickexposure from the generic Angular text-editordxi-buttonnested option base.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/ts/dx.all.d.ts | Adds documentation descriptors for ColumnButtonClickEvent and its members in the bundled declarations. |
| packages/devextreme/js/ui/tree_list.d.ts | Introduces full doc metadata for ColumnButtonClickEvent and updates dxTreeListColumnButton.onClick param doc reference. |
| packages/devextreme-vue/src/tree-list.ts | Aligns Vue wrapper onClick prop types for TreeList column buttons to ColumnButtonClickEvent. |
| packages/devextreme-react/src/tree-list.ts | Aligns React wrapper onClick prop types for TreeList column buttons to ColumnButtonClickEvent. |
| packages/devextreme-metadata/make-angular-metadata.ts | Adds a metadata mutation intended to remove ColumnButton.onClick members (risk: can affect generated Angular API). |
| packages/devextreme-angular/src/ui/tree-list/nested/column-button-dxi.ts | Updates Angular TreeList column-button onClick typing to ColumnButtonClickEvent. |
| packages/devextreme-angular/src/ui/tree-list/nested/button-dxi.ts | Updates Angular TreeList button onClick typing to ColumnButtonClickEvent. |
| packages/devextreme-angular/src/ui/nested/button-dxi.ts | Removes onClick from generic dxi-button inputs (text editor button config). |
| packages/devextreme-angular/src/ui/nested/base/text-editor-button-dxi.ts | Removes incorrect onClick accessor and unrelated ColumnButtonClickEvent import from the text-editor button base. |
| removeMembers(/\/card_view:/), | ||
| removeMembers(/\/chat:TextMessage.attachments/), | ||
| removeMembers(/\/chat:dxChatOptions\.(fileUploaderOptions|onAttachmentDownloadClick)/), | ||
| removeMembers(/\/(data_grid|tree_list):.*ColumnButton\.onClick/), |
There was a problem hiding this comment.
The new metadata mutation removes *.ColumnButton.onClick members for both DataGrid and TreeList. Those members exist (e.g. ui/data_grid:dxDataGridColumnButton.onClick, ui/tree_list:dxTreeListColumnButton.onClick) and are used to generate Angular nested option components for column buttons. Removing them will likely drop the onClick callback from the generated Angular API for column buttons.
Consider removing this mutation, or narrowing it so it only affects the specific metadata entry that incorrectly leaks into the generic dxi-button (text editor button) options, without stripping onClick from actual grid column button types. Re-run wrapper generation to confirm dxi-*-button / dxi-*-column-button still expose onClick.
| removeMembers(/\/(data_grid|tree_list):.*ColumnButton\.onClick/), |
1 participant
Patch for:
Docs: