Skip to content

[RFC] Allow to configure exception formatter #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blueyed wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[RFC] Allow to configure exception formatter #86

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dadac80
Allow for exception_formatter=None
blueyed Apr 9, 2019
1c7c7a4
Add exception_formatter kwarg to logger.add
blueyed Apr 9, 2019
cb43c84
Move instantiation of exception_formatter up
blueyed Apr 9, 2019
4fec4a4
Logger.add: append exception to formatter only with exception formatter
blueyed Apr 9, 2019
e99e482
add test_handler_with_no_exception_formatter
blueyed Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move instantiation of exception_formatter up
  • Loading branch information
@blueyed
blueyed committed Apr 9, 2019
commit cb43c842edcf95d5e87f5fddf0285ee891427814
34 changes: 17 additions & 17 deletions loguru/_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,6 +743,23 @@ def filter_func(r):
"Invalid level value, it should be a positive integer, not: %d" % levelno
)

try:
encoding = sink.encoding
except AttributeError:
encoding = None

if not encoding:
encoding = "ascii"

if exception_formatter is UNSET:
exception_formatter = ExceptionFormatter(
colorize=colorize,
encoding=encoding,
diagnose=diagnose,
backtrace=backtrace,
hidden_frames_filename=self.catch.__code__.co_filename,
)

if isinstance(format, str):
formatter = format + "\n{exception}"
is_formatter_dynamic = False
Expand All @@ -755,27 +772,10 @@ def filter_func(r):
% type(format).__name__
)

try:
encoding = sink.encoding
except AttributeError:
encoding = None

if not encoding:
encoding = "ascii"

with self._lock:
handler_id = next(self._handlers_count)
colors = [lvl.color for lvl in self._levels.values()] + [""]

if exception_formatter is UNSET:
exception_formatter = ExceptionFormatter(
colorize=colorize,
encoding=encoding,
diagnose=diagnose,
backtrace=backtrace,
hidden_frames_filename=self.catch.__code__.co_filename,
)

handler = Handler(
writer=writer,
stopper=stopper,
Expand Down