Skip to content

coverage: include tests #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blueyed wants to merge 9 commits into
base: master
Choose a base branch
from
Open

coverage: include tests #39

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1b8420b
coverage: include tests
blueyed Jan 20, 2019
f6d866b
improve test coverage
blueyed Feb 17, 2019
bf75085
re-raise for full coverage
blueyed Feb 17, 2019
ffa586b
fixup! improve test coverage
blueyed Feb 17, 2019
2e6512e
Revert "re-raise for full coverage"
blueyed Feb 17, 2019
8785466
fixup! fixup! improve test coverage
blueyed Feb 17, 2019
9cd4e57
tests/exceptions/nested_wrapping.py
blueyed Feb 18, 2019
1da9021
Report to codecov, with different flags for tests.
blueyed Feb 21, 2019
820e180
Add config for codecov
blueyed Mar 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve test coverage
  • Loading branch information
@blueyed
blueyed committed Feb 17, 2019
commit f6d866b8620cd3706d2b186be457a1f1c14050a1
4 changes: 2 additions & 2 deletions tests/test_add_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ def test_disabled_logger_in_sink(sink_with_logger):

def test_invalid_function_kwargs():
def function(message, a="Y"):
pass
raise NotImplementedError

logger.add(function, b="X", catch=False)
with pytest.raises(TypeError):
Expand All @@ -384,7 +384,7 @@ def __init__(self):
self.out = ""

def write(self, m):
pass
raise NotImplementedError

writer = Writer()
logger.add(writer, format="{message}", kw1="1", kw2="2", catch=False)
Expand Down
3 changes: 1 addition & 2 deletions tests/test_threading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ def __init__(self, sleep_time):
self.stopped = False

def write(self, message):
if self.stopped:
raise RuntimeError("Can't write on stopped sink")
assert not self.stopped

length = len(message)
self.written += message[:length]
Expand Down
4 changes: 3 additions & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@ source = .

[coverage:report]
include = loguru/*, tests/*

exclude_lines =
\#\s*pragma: no cover
^\s*raise NotImplementedError\b