Skip to content

Updating order of operations for applying patchers #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rawrke wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updating order of operations for applying patchers #1345

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87ed186
Rearranging patch calls
May 20, 2025
c018f5f
Adding tests
May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adding tests
  • Loading branch information
Evan Rourke committed May 20, 2025
commit c018f5f26c6506463406702711c88e64f680c422
47 changes: 47 additions & 0 deletions tests/test_patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
import re

import pytest

from loguru import logger


Expand Down Expand Up @@ -83,3 +87,46 @@ def patch_3(record):
logger.patch(patch_1).patch(patch_2).patch(patch_3).info("Test")

assert writer.read() == "12 Test\n"


@pytest.mark.parametrize(
("colorize", "colors", "expected"),
[
(False, False, "<red>A</red>\n"),
(False, True, "A\n"),
(True, False, "<red>A</red>\n"),
(True, True, "\x1b[31mA\x1b[0m\n"),
],
)
def test_colorful_patch(colorize, colors, expected, writer):
logger.add(writer, format="{message}", colorize=colorize)

logger_patched = logger.patch(lambda r: r.update(message=f"<red>{r['message']}</red>"))
logger_patched.opt(colors=colors).debug("A")

assert writer.read() == expected


@pytest.mark.parametrize(
("colorize", "colors", "expected"),
[
(False, False, "A <red>W</red>, <red>M</red>\n"),
(False, True, "A W, M\n"),
(True, False, "A <red>W</red>, <red>M</red>\n"),
(True, True, "A \x1b[31mW\x1b[0m, \x1b[31mM\x1b[0m\n"),
],
)
def test_automatic_colorful_patch(colorize, colors, expected, writer):
# regex matches on single curly braces and substitutes
# a color tag in-place
_regex_pattern = re.compile(r"(\{[^{}]*\})(?!\})")
_regex_repl = r"<red>\1</red>"

def patch(r):
r.update(message=re.sub(_regex_pattern, _regex_repl, r["message"]))

logger.add(writer, format="{message}", colorize=colorize)
logger_patched = logger.patch(patch)
logger_patched.opt(colors=colors).debug("A {}, {a}", "W", a="M")

assert writer.read() == expected
Loading