Skip to content

add in aria attributes#8086

Closed
wmill wants to merge 1 commit into
DefinitelyTyped:masterfrom
wmill:new-aria-labels
Closed

add in aria attributes#8086
wmill wants to merge 1 commit into
DefinitelyTyped:masterfrom
wmill:new-aria-labels

Conversation

@wmill

@wmill wmill commented Feb 14, 2016

Copy link
Copy Markdown

Aria attributes are used to provide hints to accessibility software.

https://www.w3.org/TR/wai-aria/states_and_properties

@dt-bot

dt-bot commented Feb 14, 2016

Copy link
Copy Markdown
Member

react/react-0.13.3.d.ts

to authors (@pspeter3 @vsiao AssureSign (account can't be detected) Microsoft (account can't be detected)). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@vsiao

vsiao commented Feb 16, 2016

Copy link
Copy Markdown
Contributor

👎

aria- attributes aren't set like this. They're also not whitelisted explicitly (see https://github.com/facebook/react/blob/master/src/renderers/dom/shared/HTMLDOMPropertyConfig.js#L26-L28).

@wmill

wmill commented Feb 16, 2016

Copy link
Copy Markdown
Author

@vsiao But doesn't typescript require them to be explicitly whitelisted? It seems like how react implements support isn't really relevant.

@mhegazy

mhegazy commented Jun 26, 2016

Copy link
Copy Markdown
Contributor

@vsiao, and @RyanCavanaugh final thoughts about this PR?

@vsiao

vsiao commented Jun 27, 2016

Copy link
Copy Markdown
Contributor

@wmill sorry if I wasn't clear. This isn't how aria attributes work. For example, instead of

React.createElement("div", { ariaHidden: true });

you must use

React.createElement("div", { "aria-hidden": true });

I don't know if TSX supports this. Maybe @RyanCavanaugh can chime in?

@mhegazy mhegazy added Revision needed This PR needs code changes before it can be merged. and removed Awaiting reviewer feedback labels Jun 27, 2016
@wmill

wmill commented Jun 27, 2016

Copy link
Copy Markdown
Author

I think this was fixed separately...

#8027

#8236

@wmill wmill closed this Jun 27, 2016
@craigkovatch

craigkovatch commented Dec 29, 2017

Copy link
Copy Markdown
Contributor

#8236 would have over-fixed this and doesn't appear to still be present in HEAD.

I'm working on a different take on this pull that I'll submit separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Revision needed This PR needs code changes before it can be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants