Repository navigation
Restore string in all non-printf-style overloads to accept message union types like string | Error - #75846
Open
ulrichb wants to merge 1 commit into
Open
Restore string in all non-printf-style overloads to accept message union types like string | Error#75846ulrichb wants to merge 1 commit into
string in all non-printf-style overloads to accept message union types like string | Error#75846ulrichb wants to merge 1 commit into
Conversation
Contributor
|
@ulrichb Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75846,
"author": "ulrichb",
"headCommitOid": "6da3230d1e7c8dd0717e3d713efd16b428a5081c",
"mergeBaseOid": "7347d8e7f785a39a6e499c13d4563304d4170ede",
"lastPushDate": "2026-10-24T23:03:08.000Z",
"lastActivityDate": "2026-10-24T23:03:08.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"version": "26.6",
"kind": "edit",
"files": [
{
"path": "types/node/assert.d.ts",
"kind": "definition"
},
{
"path": "types/node/assert/strict.d.ts",
"kind": "definition"
},
{
"path": "types/node/node-tests/assert.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"jkomyno",
"r3nya",
"btoueg",
"touffy",
"mohsen1",
"galkin",
"eps1lon",
"WilcoBakker",
"trivikr",
"yoursunny",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky",
"Renegade334",
"anonrig"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 6390572594,
"ciResult": "pass"
} |
Contributor
|
🔔 @microsoft @jkomyno @r3nya @btoueg @Touffy @mohsen1 @galkin @eps1lon @WilcoBakker @trivikr @yoursunny @ExE-Boss @peterblazejewicz @addaleax @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky @Renegade334 @anonrig — please review this PR in the next few days. Be sure to explicitly select |
typescript-automation
Bot
moved this to Waiting for Code Reviews
in Pull Request Status Board
…union types like `string | Error` * This was a regression of the node 26 typings introduced in f92b5dc.
ulrichb
force-pushed
the
NodeAssertOverloads
branch
from
October 24, 2026 23:03
e9aa0bf to
6da3230
Compare
typescript-automation
Bot
moved this from Waiting for Code Reviews
to Needs Maintainer Review
in Pull Request Status Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.