[safie-sdk] Add type definitions#75014
Open
yusuke-oba1 wants to merge 2 commits into
Open
Conversation
Type definitions for the Safie Developers JavaScript SDK distributed via CDN from https://developers.safie.link/. This is a non-npm package that declares the global Safie namespace exposed by the SDK when loaded as a <script> tag.
Contributor
|
@yusuke-oba1 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75014,
"author": "yusuke-oba1",
"headCommitOid": "84d893eab091fe78c932364875074403655adcbc",
"mergeBaseOid": "c6fb7d2e0e833931ac92da131709d2c6178ce3d8",
"lastPushDate": "2026-05-18T01:00:25.000Z",
"lastActivityDate": "2026-05-18T01:00:25.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "safie-sdk",
"kind": "add",
"files": [
{
"path": "types/safie-sdk/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/safie-sdk/index.d.ts",
"kind": "definition"
},
{
"path": "types/safie-sdk/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/safie-sdk/safie-sdk-tests.ts",
"kind": "test"
},
{
"path": "types/safie-sdk/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"SafieDev"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 4473279812,
"ciResult": "pass"
} |
typescript-bot
added
the
New Definition
Contributor
|
🔔 @yusuke-oba1 — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Action
in Pull Request Status Board
typescript-bot
added
the
Where is GH Actions?
typescript-bot
moved this from Needs Maintainer Action
to Other
in Pull Request Status Board
typescript-bot
removed
the
Where is GH Actions?
typescript-bot
moved this from Other
to Needs Maintainer Action
in Pull Request Status Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type definitions for the Safie Developers JavaScript SDK distributed via CDN from https://developers.safie.link/.
This is a non-npm package that declares the global Safie namespace exposed by the SDK when loaded as a
<script>tag.pnpm test <package to test>.If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.dts-gen, the declarations were generated from the SDK's own TypeScript source viatsc --declarationand then post-processed to fit the DefinitelyTyped global-namespace conventions. This yields more accurate types than runtime introspection bydts-gen.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.