@unrevised6419 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

1 package in this PR (and infra files)

• koa — on npm, on unpkg
  • Config files to check:
    • koa/v2/.eslintrc.json: not the expected form (check: rules)
• Infra files
  • attw.json

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ A DT maintainer needs to approve changes that affect DT infrastructure (attw.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 74990,
  "author": "unrevised6419",
  "headCommitOid": "11fda3790e538c0f90289a89c635f0b9a01d3bd5",
  "mergeBaseOid": "3c0b15fc1e4e9a3ab449e463673b3c33355c9e85",
  "lastPushDate": "2026-05-12T18:23:14.000Z",
  "lastActivityDate": "2026-05-14T20:20:29.000Z",
  "mergeOfferDate": "2026-05-14T19:56:00.000Z",
  "mergeRequestDate": "2026-05-14T20:20:29.000Z",
  "mergeRequestUser": "unrevised6419",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "attw.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical",
      "isSafeInfrastructureEdit": false
    },
    {
      "name": "koa",
      "kind": "edit",
      "files": [
        {
          "path": "types/koa/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/koa/v2/.eslintrc.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-eslintrcjson) (check: `rules`)"
        },
        {
          "path": "types/koa/v2/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/koa/v2/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/koa/v2/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/koa/v2/test/constructor.ts",
          "kind": "test"
        },
        {
          "path": "types/koa/v2/test/default.ts",
          "kind": "test"
        },
        {
          "path": "types/koa/v2/test/index.ts",
          "kind": "test"
        },
        {
          "path": "types/koa/v2/test/settings.ts",
          "kind": "test"
        },
        {
          "path": "types/koa/v2/test/typed-response-body.ts",
          "kind": "test"
        },
        {
          "path": "types/koa/v2/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "jkeylu",
        "brikou",
        "harryparkdotio",
        "chatoo2412",
        "tellnes",
        "pkuczynski",
        "vnoder"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2026-05-14T19:55:20.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "pkuczynski",
      "date": "2026-05-12T18:51:41.000Z",
      "abbrOid": "c7f51d7"
    }
  ],
  "mainBotCommentID": 4433490854,
  "ciResult": "pass"
}

🔔 @jkeylu @brikou @harryparkdotio @chatoo2412 @tellnes @pkuczynski @vnoder — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

This code doesn't match what's in https://app.unpkg.com/@types/koa@2.15.0; the import syntax is different and the dependencies are different. Is that all intentional?

Only these two commits where not reverted intentionally

9a370b0
2f29f0c

Let me do some more tests locally on https://github.com/strapi/strapi

I'm installing it locally directly from the path, but I guess there should be some process for release, or how can I pack it locally?

You can run pnpm pack inside the dir to get an approximation. The npmignore should be accurate.

Tried pnpm pack, from what I saw only package.json does not match, will try to copy it from the last released @types/koa version

I'll try to see how I can do a "real" pack locally using https://github.com/microsoft/DefinitelyTyped-tools/tree/main/packages/publisher

The publisher just builds the tarball directly from the source.

I'm not sure what you're missing, but in the published package, it's:

import * as accepts from "accepts";
import { AsyncLocalStorage } from "async_hooks";
import * as Cookies from "cookies";
import { EventEmitter } from "events";
import { IncomingHttpHeaders, IncomingMessage, OutgoingHttpHeaders, Server, ServerResponse } from "http";
import { Http2ServerRequest, Http2ServerResponse } from "http2";
import httpAssert = require("http-assert");
import * as contentDisposition from "content-disposition";
import * as HttpErrors from "http-errors";
import * as Keygrip from "keygrip";
import * as compose from "koa-compose";
import { ListenOptions, Socket } from "net";
import { ParsedUrlQuery } from "querystring";
import * as url from "url";

But here, you've written:

import accepts = require("accepts");
import { AsyncLocalStorage } from "async_hooks";
import Cookies = require("cookies");
import { EventEmitter } from "events";
import { IncomingHttpHeaders, IncomingMessage, OutgoingHttpHeaders, Server, ServerResponse } from "http";
import { Http2ServerRequest, Http2ServerResponse } from "http2";
import httpAssert = require("http-assert");
import contentDisposition = require("content-disposition");
import HttpErrors = require("http-errors");
import Keygrip = require("keygrip");
import compose = require("koa-compose");
import { ListenOptions, Socket } from "net";
import { ParsedUrlQuery } from "querystring";
import * as url from "url";

Differences can be okay, I am just asking for an explanation.

It seems these changes were made by the DefinitelyTyped maintainers in 9a370b0#diff-bb94074d9ae1164d531dd6eb17a8858f06f4129662469a7d5e1dd19cb5eed86c (see files in types/koa/) across the DefinitelyTyped, that's why I did not revert them 🤔

#73954

Should I revert them back to what was in 2.15.0?

I'll do some more tests tomorrow.

I see. I am unsure why that was not published to npm.

What about the package.json diff?

That DefinitelyTyped core change was made after the koa v3 types release, that's why it did not land in v2

Will revert the package.json diff also. I suppose it needs to be * and DefinitelyTyped picks the right version itself 🤔

That'll end up picking an arbitrary one, and then likely the latest, so you should just check koa v2 upstream to see what they use.

Ok. Will do so. Strange why previously all versions were *

Question: Why all of the package.json#dependencies.<name> across the /DefinitelyTyped, use * as the version?
As you said, won't they resolve to any (latest) version?
Should they match the right versions that the package uses?

I did revert the package.json to be exactly as it was in @types/koa@2.15.0

Using current PR and this one #74991
I did some testing in strapi/strapi#25424, and it seems to work fine.

@pkuczynski Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@unrevised6419: Everything looks good here. I am ready to merge this PR (at 11fda37) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@jkeylu, @brikou, @harryparkdotio, @chatoo2412, @tellnes, @pkuczynski, @vnoder: you can do this too.)

Ready to merge