Update types for @types/dom-navigation#74469
Update types for @types/dom-navigation#74469jeffydc wants to merge 2 commits intoDefinitelyTyped:masterfrom
@types/dom-navigation#74469Conversation
jeffydc
changed the title
dom-navigationdom-navigation
|
@jeffydc Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74469,
"author": "jeffydc",
"headCommitOid": "fc9691922da5eff1130daea30a335c57336f81bb",
"mergeBaseOid": "e6b9bf3e1e9624a311ba3681710b2592e781c7d0",
"lastPushDate": "2026-02-04T16:30:52.000Z",
"lastActivityDate": "2026-02-04T16:50:27.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "dom-navigation",
"kind": "edit",
"files": [
{
"path": "types/dom-navigation/dom-navigation-tests.ts",
"kind": "test"
},
{
"path": "types/dom-navigation/index.d.ts",
"kind": "definition"
}
],
"owners": [
"tbondwilkinson"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 3848471382,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/fc9691922da5eff1130daea30a335c57336f81bb/checks?check_suite_id=56462676317"
} |
|
🔔 @tbondwilkinson — please review this PR in the next few days. Be sure to explicitly select |
jeffydc
changed the title
dom-navigationdom-navigation
jeffydc
changed the title
dom-navigation@types/dom-navigation] Update types for dom-navigation
typescript-bot
moved this from Waiting for Code Reviews
to Needs Author Action
in Pull Request Status Board
|
@jeffydc The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
jeffydc
changed the title
@types/dom-navigation] Update types for dom-navigation@types/dom-navigation
| readonly finished: Promise<void>; | ||
| } | ||
|
|
||
| // declare class NavigationActivation { |
There was a problem hiding this comment.
I need a guidance on how shall we proceed for this type?
NavigationActivation does not exist until TS 5.8.
Shall we use typesVersion for this or bump the TS version requirement?
|
according to [npmjs.org](https://www.npmjs.com/package/dom-navigation], dom-navigation contains malicious code and was removed from the registry by the npm security team so i am a little bit concerned about downloading and testing it |
typescript-bot
moved this from Needs Author Action
to Waiting for Code Reviews
in Pull Request Status Board
|
@jeffydc The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Author Action
in Pull Request Status Board
3 participants
This PR updates the types of dom-navigation to match with the latest spec.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.