Skip to content

[react] Backport recent changes to TS 5.0 fork#74452

Merged
eps1lon merged 4 commits intoDefinitelyTyped:masterfrom
eps1lon:sebbie/react-sync-forks
Feb 5, 2026
Merged

[react] Backport recent changes to TS 5.0 fork#74452
eps1lon merged 4 commits intoDefinitelyTyped:masterfrom
eps1lon:sebbie/react-sync-forks

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Feb 3, 2026

Stacked on #74451

Backports

Consistently uses import * as React. I don't understand why this got changed in #73954 when it also enabled esModuleInterop

@typescript-bot typescript-bot moved this to Needs Author Action in Pull Request Status Board Feb 3, 2026
@eps1lon eps1lon marked this pull request as ready for review February 3, 2026 22:40
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 3, 2026

@eps1lon Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes that affect module config files

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74452,
  "author": "eps1lon",
  "headCommitOid": "6bdb063a3221712836cbfb561ce735aff738ac59",
  "mergeBaseOid": "7e7c5cac08d4c9a13f29c8fdabe6bb66ba79f230",
  "lastPushDate": "2026-02-03T18:48:42.000Z",
  "lastActivityDate": "2026-02-05T09:45:40.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/test/hooks.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/test/managedAttributes.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/ts5.0/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/ts5.0/test/elementAttributes.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/ts5.0/test/index.ts",
          "kind": "test"
        },
        {
          "path": "types/react/ts5.0/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.lib.0`, `compilerOptions.exactOptionalPropertyTypes`, `compilerOptions.esModuleInterop`)"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "priyanshurav",
        "Semigradsky",
        "mattpocock"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 3844138267,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Edits multiple packages Author is Owner The author of this PR is a listed owner of the package. Check Config Changes a module config files labels Feb 3, 2026
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in Pull Request Status Board Feb 3, 2026
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 3, 2026

@sheetalkamat sheetalkamat moved this from Needs Maintainer Review to Waiting for Code Reviews (Blessed) in Pull Request Status Board Feb 3, 2026
@eps1lon eps1lon force-pushed the sebbie/react-sync-forks branch from be47142 to 50b1923 Compare February 4, 2026 11:10
@typescript-bot typescript-bot moved this from Waiting for Code Reviews (Blessed) to Waiting for Code Reviews in Pull Request Status Board Feb 4, 2026
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Feb 4, 2026
@typescript-bot
Copy link
Contributor

@eps1lon The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in Pull Request Status Board Feb 4, 2026
@eps1lon eps1lon force-pushed the sebbie/react-sync-forks branch from 50b1923 to 6bdb063 Compare February 5, 2026 09:45
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Feb 5, 2026
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board Feb 5, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Feb 5, 2026
@eps1lon eps1lon merged commit 4d0de1c into DefinitelyTyped:master Feb 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Check Config Changes a module config files Critical package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants