[tabulator-tables] Add mutateLink to ColumnDefinition#74443
[tabulator-tables] Add mutateLink to ColumnDefinition#74443gormster wants to merge 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@gormster Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74443,
"author": "gormster",
"headCommitOid": "11ab58d57661af77e4964510763e04bd714115f2",
"mergeBaseOid": "569bc1702e4fab2630fcc46245c104e4a00f3f0f",
"lastPushDate": "2026-02-02T03:03:26.000Z",
"lastActivityDate": "2026-02-02T08:46:30.000Z",
"maintainerBlessed": "Waiting for Code Reviews (Blessed)",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "tabulator-tables",
"kind": "edit",
"files": [
{
"path": "types/tabulator-tables/index.d.ts",
"kind": "definition"
}
],
"owners": [
"jojoshua",
"mike-lischke"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 3832662799,
"ciResult": "pass"
} |
|
Hey @gormster, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @Jojoshua @mike-lischke — please review this PR in the next few days. Be sure to explicitly select |
Error TypeErrorDangerfile |
|
There's no tests for mutators at all rn - I'm not even sure how I'd write them - so I thought that probably better left to someone who's more familiar with both the Tabulator codebase and unit testing in DT. |
|
@gormster The tests here do not read or set any value. It's all about syntax. In the test file you write some code, which must be allowed by the type definitions. In your case just add a column definition at the end of the test file, which uses a mutator. You can probably use your own code here, for which you added the mutateLink field. |
Adds a missing field from ColumnDefinition: see https://tabulator.info/docs/6.3/mutators#mutator-link
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
package.json.If removing a declaration:
notNeededPackages.json.