Skip to content

[tabulator-tables] Add mutateLink to ColumnDefinition#74443

Open
gormster wants to merge 1 commit intoDefinitelyTyped:masterfrom
gormster:patch-1
Open

[tabulator-tables] Add mutateLink to ColumnDefinition#74443
gormster wants to merge 1 commit intoDefinitelyTyped:masterfrom
gormster:patch-1

Conversation

@gormster
Copy link

@gormster gormster commented Feb 2, 2026

Adds a missing field from ColumnDefinition: see https://tabulator.info/docs/6.3/mutators#mutator-link

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 2, 2026

@gormster Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74443,
  "author": "gormster",
  "headCommitOid": "11ab58d57661af77e4964510763e04bd714115f2",
  "mergeBaseOid": "569bc1702e4fab2630fcc46245c104e4a00f3f0f",
  "lastPushDate": "2026-02-02T03:03:26.000Z",
  "lastActivityDate": "2026-02-02T08:46:30.000Z",
  "maintainerBlessed": "Waiting for Code Reviews (Blessed)",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "tabulator-tables",
      "kind": "edit",
      "files": [
        {
          "path": "types/tabulator-tables/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jojoshua",
        "mike-lischke"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 3832662799,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Feb 2, 2026
@typescript-bot
Copy link
Contributor

Hey @gormster,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Feb 2, 2026
@typescript-bot
Copy link
Contributor

🔔 @Jojoshua @mike-lischke — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link

Fails
🚫

Danger failed to run dangerfile.ts.

Error TypeError

Cannot read properties of null (reading 'filename')
TypeError: Cannot read properties of null (reading 'filename')
    at shouldUseGitHubOverride (/home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/.pnpm/danger@11.3.1_encoding@0.1.13/node_modules/danger/distribution/platforms/github/customGitHubRequire.js:131:16)
    at _module2.default._load (/home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/.pnpm/override-require@1.1.1/node_modules/override-require/dist/overrideRequire.js:38:9)
    at node:internal/modules/esm/translators:273:15
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:240:7)
    at ModuleJobSync.runSync (node:internal/modules/esm/module_job:437:37)
    at ModuleLoader.importSyncForRequire (node:internal/modules/esm/loader:389:47)
    at loadESMFromCJS (node:internal/modules/cjs/loader:1363:24)
    at Module._compile (node:internal/modules/cjs/loader:1503:5)
    at requireFromString (/home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/.pnpm/require-from-string@2.0.2/node_modules/require-from-string/index.js:28:4)
    at /home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/.pnpm/danger@11.3.1_encoding@0.1.13/node_modules/danger/distribution/runner/runners/inline.js:161:68

Dangerfile

126|     // number of backticks cannot close the block.
127|     const codeBlock = "``````````";
128|     const message = [
129|         "## Formatting errors",
130|         "",
-------------------^
131|         codeBlock,
132|         ...dprintErrors.join("\n\n"),
133|         codeBlock,
134|     ];

Generated by 🚫 dangerJS against 11ab58d

@gormster
Copy link
Author

gormster commented Feb 2, 2026

There's no tests for mutators at all rn - I'm not even sure how I'd write them - so I thought that probably better left to someone who's more familiar with both the Tabulator codebase and unit testing in DT.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Feb 2, 2026
@mike-lischke
Copy link
Contributor

@gormster The tests here do not read or set any value. It's all about syntax. In the test file you write some code, which must be allowed by the type definitions. In your case just add a column definition at the end of the test file, which uses a mutator. You can probably use your own code here, for which you added the mutateLink field.

@sheetalkamat sheetalkamat moved this from Needs Maintainer Review to Waiting for Code Reviews (Blessed) in Pull Request Status Board Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Untested Change This PR does not touch tests

Projects

Status: Waiting for Code Reviews (Blessed)

Development

Successfully merging this pull request may close these issues.

4 participants