Skip to content

[chrome] update since Chrome 145#74432

Open
erwanjugand wants to merge 1 commit intoDefinitelyTyped:masterfrom
erwanjugand:chrome145
Open

[chrome] update since Chrome 145#74432
erwanjugand wants to merge 1 commit intoDefinitelyTyped:masterfrom
erwanjugand:chrome145

Conversation

@erwanjugand
Copy link
Contributor

@erwanjugand erwanjugand commented Jan 31, 2026 •
edited
Loading

Please fill in this template.

If changing an existing definition:

Notes:

  • add bookmarks.ROOT_NODE_ID const
  • update tabs.Tab: add splitViewId key
  • add tabs.SPLIT_VIEW_ID_NONE const
  • add declarativeNetRequest.RuleConditionKeys enum
  • update declarativeNetRequest.TestMatchRequestDetails: add topUrl key
  • update tests

Runtime (Beta):
image

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 31, 2026 •
edited
Loading

@erwanjugand Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 74432,
  "author": "erwanjugand",
  "headCommitOid": "42886ba1c974cd760ffb09babbee6a8eb1bfab41",
  "mergeBaseOid": "4f5c19f187c6b8fd550d72eed781c11307bcdf37",
  "lastPushDate": "2026-01-31T12:30:10.000Z",
  "lastActivityDate": "2026-02-03T13:58:12.000Z",
  "maintainerBlessed": "Waiting for Code Reviews (Blessed)",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "chrome",
      "kind": "edit",
      "files": [
        {
          "path": "types/chrome/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/chrome/test/index.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "matthewkimber",
        "otiai10",
        "sreimer15",
        "MatCarlson",
        "ekinsol",
        "echoabstract",
        "spasma",
        "bdbai",
        "JasonXian",
        "usertim",
        "idan315",
        "nicolas377",
        "idosal",
        "fregante",
        "erwanjugand"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 3828375858,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Jan 31, 2026
@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Jan 31, 2026
@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 31, 2026

🔔 @matthewkimber @otiai10 @sreimer15 @matcarlson @ekinsol @EchoAbstract @spasma @bdbai @JasonXian @userTim @idan315 @nicolas377 @idosal @fregante — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link

DangerBotOSS commented Jan 31, 2026 •
edited
Loading

Fails
🚫

Danger failed to run dangerfile.ts.

Error TypeError

Cannot read properties of null (reading 'filename')
TypeError: Cannot read properties of null (reading 'filename')
    at shouldUseGitHubOverride (/home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/.pnpm/danger@11.3.1_encoding@0.1.13/node_modules/danger/distribution/platforms/github/customGitHubRequire.js:131:16)
    at _module2.default._load (/home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/.pnpm/override-require@1.1.1/node_modules/override-require/dist/overrideRequire.js:38:9)
    at node:internal/modules/esm/translators:273:15
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:240:7)
    at ModuleJobSync.runSync (node:internal/modules/esm/module_job:437:37)
    at ModuleLoader.importSyncForRequire (node:internal/modules/esm/loader:389:47)
    at loadESMFromCJS (node:internal/modules/cjs/loader:1363:24)
    at Module._compile (node:internal/modules/cjs/loader:1503:5)
    at requireFromString (/home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/.pnpm/require-from-string@2.0.2/node_modules/require-from-string/index.js:28:4)
    at /home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/.pnpm/danger@11.3.1_encoding@0.1.13/node_modules/danger/distribution/runner/runners/inline.js:161:68

Dangerfile

126|     // number of backticks cannot close the block.
127|     const codeBlock = "``````````";
128|     const message = [
129|         "## Formatting errors",
130|         "",
-------------------^
131|         codeBlock,
132|         ...dprintErrors.join("\n\n"),
133|         codeBlock,
134|     ];

Generated by 🚫 dangerJS against a0d416b

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Jan 31, 2026
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Jan 31, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Jan 31, 2026
@sheetalkamat sheetalkamat moved this from Needs Maintainer Review to Waiting for Code Reviews (Blessed) in Pull Request Status Board Feb 2, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews (Blessed) to Waiting for Code Reviews in Pull Request Status Board Feb 3, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Feb 3, 2026
@sheetalkamat sheetalkamat moved this from Needs Maintainer Review to Waiting for Code Reviews (Blessed) in Pull Request Status Board Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Author is Owner The author of this PR is a listed owner of the package. Critical package

Projects

Pull Request Status Board
Status: Waiting for Code Reviews (Blessed)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erwanjugand @typescript-bot @DangerBotOSS