Skip to content

Add types for k6/x/socketio#74419

Open
XEmAX32 wants to merge 2 commits intoDefinitelyTyped:masterfrom
XEmAX32:master
Open

Add types for k6/x/socketio#74419
XEmAX32 wants to merge 2 commits intoDefinitelyTyped:masterfrom
XEmAX32:master

Conversation

@XEmAX32
Copy link

@XEmAX32 XEmAX32 commented Jan 30, 2026

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 30, 2026

@XEmAX32 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 7 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74419,
  "author": "XEmAX32",
  "headCommitOid": "80f3e6fbea60839d4f7efc3430cffcfefd4484c7",
  "mergeBaseOid": "c0e4c41164885d5d2d40845848b4d64782d7ca61",
  "lastPushDate": "2026-01-30T00:11:27.000Z",
  "lastActivityDate": "2026-02-03T20:21:42.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "k6__x__socketio",
      "kind": "add",
      "files": [
        {
          "path": "types/k6__x__socketio/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/k6__x__socketio/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/k6__x__socketio/k6__x__socketio-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/k6__x__socketio/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/k6__x__socketio/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.lib.0`)"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 3821060593,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Check Config Changes a module config files labels Jan 30, 2026
@typescript-bot
Copy link
Contributor

🔔 @XEmAX32 — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Jan 30, 2026
@DangerBotOSS
Copy link

Formatting

The following files are not formatted:

  1. types/k6__x__socketio/package.json
  2. types/k6__x__socketio/tsconfig.json
  3. types/k6__x__socketio/k6__x__socketio-tests.ts
  4. types/k6__x__socketio/index.d.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against e463104

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board Jan 30, 2026
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Code Reviews in Pull Request Status Board Feb 2, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board Feb 2, 2026
@sheetalkamat
Copy link
Contributor

The package.json added indicates this is for non npm package. The project URL seems to be inaccessible. Is this any how related to package k6 which we already have definitions for. We are currently not sure what's going on here to review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Check Config Changes a module config files New Definition This PR creates a new definition package.

Projects

Status: Needs Maintainer Action

Development

Successfully merging this pull request may close these issues.

4 participants