fix(nodemailer): Add missing secured option#74407
Open
oldium wants to merge 1 commit intoDefinitelyTyped:masterfrom
Open
fix(nodemailer): Add missing secured option#74407oldium wants to merge 1 commit intoDefinitelyTyped:masterfrom
oldium wants to merge 1 commit intoDefinitelyTyped:masterfrom
Conversation
Contributor
|
@oldium Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 8 days. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74407,
"author": "oldium",
"headCommitOid": "eb5aea6808eea78c44454fe8f8c79046f452772d",
"mergeBaseOid": "1bfb3a01af9c94ad7c913a0f6359b3bfb8205602",
"lastPushDate": "2026-01-27T18:24:56.000Z",
"lastActivityDate": "2026-01-31T00:17:04.000Z",
"maintainerBlessed": "Waiting for Code Reviews (Blessed)",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "nodemailer",
"kind": "edit",
"files": [
{
"path": "types/nodemailer/lib/smtp-connection/index.d.ts",
"kind": "definition"
},
{
"path": "types/nodemailer/nodemailer-tests.ts",
"kind": "test"
},
{
"path": "types/nodemailer/v6/lib/smtp-connection/index.d.ts",
"kind": "definition"
},
{
"path": "types/nodemailer/v6/nodemailer-tests.ts",
"kind": "test"
}
],
"owners": [
"rogierschouten",
"dex4er",
"bioball"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 3806792402,
"ciResult": "pass"
} |
typescript-bot
added
Critical package
Untested Change
Contributor
|
🔔 @rogierschouten @dex4er @bioball — please review this PR in the next few days. Be sure to explicitly select |
oldium
force-pushed
the
fix/secured-option
branch
from
9bcd875 to
9504f6e
Compare
Author
|
Added simple test |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Review
in Pull Request Status Board
oldium
force-pushed
the
fix/secured-option
branch
from
9504f6e to
34c9ba1
Compare
typescript-bot
moved this from Needs Maintainer Review
to Waiting for Code Reviews
in Pull Request Status Board
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Review
in Pull Request Status Board
oldium
force-pushed
the
fix/secured-option
branch
from
34c9ba1 to
eb5aea6
Compare
typescript-bot
moved this from Needs Maintainer Review
to Waiting for Code Reviews
in Pull Request Status Board
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Review
in Pull Request Status Board
Author
|
Updated wording to match the documentation |
sheetalkamat
moved this from Needs Maintainer Review
to Waiting for Code Reviews (Blessed)
in Pull Request Status Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.