feat(artillery): remove types#74395
Conversation
|
@hkleungai Thank you for submitting this PR! This is a live comment that I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 1 package in this PR (and infra files)Code ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74395,
"author": "hkleungai",
"headCommitOid": "d230a0c164dcd92fb018055747735c65381dea58",
"mergeBaseOid": "24d18581e90b8098e9120355ad871c62e40ca4bc",
"lastPushDate": "2026-01-25T07:39:04.000Z",
"lastActivityDate": "2026-02-02T20:20:40.000Z",
"mergeOfferDate": "2026-02-02T20:21:22.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical",
"isSafeInfrastructureEdit": false
},
{
"name": "artillery",
"kind": "delete",
"files": [
{
"path": "types/artillery/.eslintrc.json",
"kind": "package-meta-ok"
},
{
"path": "types/artillery/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/artillery/artillery-tests.ts",
"kind": "test"
},
{
"path": "types/artillery/index.d.ts",
"kind": "definition"
},
{
"path": "types/artillery/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/artillery/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"BendingBender"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sheetalkamat",
"date": "2026-02-02T20:20:40.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 3796146612,
"ciResult": "pass"
} |
|
🔔 @BendingBender — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Action
in Pull Request Status Board
typescript-bot
added
Maintainer Approved
Self Merge
|
@hkleungai: Everything looks good here. I am ready to merge this PR (at d230a0c) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@BendingBender: you can do this too.) |
typescript-bot
moved this from Needs Maintainer Action
to Waiting for Author to Merge
in Pull Request Status Board
3 participants
See https://app.unpkg.com/artillery@2.0.25/files/package.json, https://app.unpkg.com/artillery@2.0.26/files/package.json.
From npm, v1.x is already deprecated. Hence this package should be safe to be removed.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If removing a declaration:
notNeededPackages.json.