Skip to content

Update dom-mediacapture-record for TS 5.7 - #70714

Merged
sandersn merged 1 commit into
DefinitelyTyped:masterfrom
sandersn:update-dom-mediacapture-record-for-ts5.7
Oct 3, 2024
Merged

Update dom-mediacapture-record for TS 5.7#70714
sandersn merged 1 commit into
DefinitelyTyped:masterfrom
sandersn:update-dom-mediacapture-record-for-ts5.7

Conversation

@sandersn

Copy link
Copy Markdown
Contributor

Required by the TS 5.7 PR: microsoft/TypeScript#60061

Note that this won't pass tests until TS 5.7 is available as a version on DT.

Required by the TS 5.7 PR: microsoft/TypeScript#60061

Note that this won't pass tests until TS 5.7 is available as a version on DT.
@typescript-bot

typescript-bot commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

@sandersn Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 70714,
  "author": "sandersn",
  "headCommitOid": "6920cf6a6e208532c7eb9b77780e21ab934d7204",
  "mergeBaseOid": "d2a93e9ac868cab4adbba5c78830b18097400950",
  "lastPushDate": "2024-09-27T21:10:19.000Z",
  "lastActivityDate": "2024-10-03T22:05:34.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "dom-mediacapture-record",
      "kind": "edit",
      "files": [
        {
          "path": "types/dom-mediacapture-record/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/dom-mediacapture-record/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/dom-mediacapture-record/ts5.6/dom-mediacapture-record-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/dom-mediacapture-record/ts5.6/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/dom-mediacapture-record/ts5.6/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "elsmr",
        "AppLover69"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2380064393,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Sep 27, 2024
@typescript-bot

Copy link
Copy Markdown
Contributor

🔔 @elsmr @AppLover69 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Sep 27, 2024
@typescript-bot

Copy link
Copy Markdown
Contributor

@sandersn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@sandersn sandersn closed this Oct 3, 2024
@sandersn sandersn reopened this Oct 3, 2024
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Oct 3, 2024
@sandersn
sandersn merged commit 45eb067 into DefinitelyTyped:master Oct 3, 2024
@sandersn
sandersn deleted the update-dom-mediacapture-record-for-ts5.7 branch October 3, 2024 22:17
alino20 pushed a commit to alino20/DefinitelyTyped that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants