Update dom-mediacapture-record for TS 5.7 - #70714
Conversation
Required by the TS 5.7 PR: microsoft/TypeScript#60061 Note that this won't pass tests until TS 5.7 is available as a version on DT.
|
@sandersn Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 70714,
"author": "sandersn",
"headCommitOid": "6920cf6a6e208532c7eb9b77780e21ab934d7204",
"mergeBaseOid": "d2a93e9ac868cab4adbba5c78830b18097400950",
"lastPushDate": "2024-09-27T21:10:19.000Z",
"lastActivityDate": "2024-10-03T22:05:34.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "dom-mediacapture-record",
"kind": "edit",
"files": [
{
"path": "types/dom-mediacapture-record/index.d.ts",
"kind": "definition"
},
{
"path": "types/dom-mediacapture-record/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/dom-mediacapture-record/ts5.6/dom-mediacapture-record-tests.ts",
"kind": "test"
},
{
"path": "types/dom-mediacapture-record/ts5.6/index.d.ts",
"kind": "definition"
},
{
"path": "types/dom-mediacapture-record/ts5.6/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"elsmr",
"AppLover69"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [],
"mainBotCommentID": 2380064393,
"ciResult": "pass"
} |
|
🔔 @elsmr @AppLover69 — please review this PR in the next few days. Be sure to explicitly select |
|
@sandersn The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
Required by the TS 5.7 PR: microsoft/TypeScript#60061
Note that this won't pass tests until TS 5.7 is available as a version on DT.