[bluebird] fix test for TS 5.7 - #70355
Conversation
|
@gabritto Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 70355,
"author": "gabritto",
"headCommitOid": "b05cdb1d006666383d02e4fdc0ed79066030dba0",
"mergeBaseOid": "3553dd5f3053ef5ea1f306c30baa46d12eb7a06f",
"lastPushDate": "2024-08-22T18:57:32.000Z",
"lastActivityDate": "2024-08-22T19:44:58.000Z",
"mergeOfferDate": "2024-08-22T19:21:18.000Z",
"mergeRequestDate": "2024-08-22T19:44:58.000Z",
"mergeRequestUser": "gabritto",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "bluebird",
"kind": "edit",
"files": [
{
"path": "types/bluebird/bluebird-tests.ts",
"kind": "test"
}
],
"owners": [
"lhecker"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "lhecker",
"date": "2024-08-22T19:27:20.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2024-08-22T19:20:42.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2305434360,
"ciResult": "pass"
} |
|
🔔 @lhecker — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
added
Maintainer Approved
Self Merge
|
@gabritto: Everything looks good here. I am ready to merge this PR (at b05cdb1) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@lhecker: you can do this too.) |
typescript-bot
added
the
Owner Approved
|
Ready to merge |
4 participants
Fixes test to avoid new errors introduced by this TS PR merged for TS 5.7.