Draft: [react] Add jsx autoComplete types from the DOM - #66982
Draft: [react] Add jsx autoComplete types from the DOM#66982yanndinendal wants to merge 2 commits into
Conversation
|
@yanndinendal Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 2 packages in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 31 days — it is considered abandoned, and therefore closed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66982,
"author": "yanndinendal",
"headCommitOid": "ec91ab78cc4ec7b5c6257567f86a46ad02fd930c",
"mergeBaseOid": "29922e5da1baf2c5e9b7ccc8c596876cd399dc49",
"lastPushDate": "2023-10-09T10:49:20.000Z",
"lastActivityDate": "2023-10-09T16:45:38.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react-dom",
"kind": "edit",
"files": [
{
"path": "types/react-dom/test/react-dom-tests.tsx",
"kind": "test"
}
],
"owners": [
"MartynasZilinskas",
"theruther4d",
"Jessidhia",
"eps1lon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/index.d.ts",
"kind": "definition"
},
{
"path": "types/react/test/elementAttributes.tsx",
"kind": "test"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"hellatan",
"priyanshurav",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 1752777520,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/ec91ab78cc4ec7b5c6257567f86a46ad02fd930c/checks?check_suite_id=17026740361"
} |
|
🔔 @MartynasZilinskas @theruther4d @Jessidhia @eps1lon @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
|
@yanndinendal The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
eps1lon
left a comment
eps1lon
left a comment
There was a problem hiding this comment.
I love the change but it requires some more effort to work around some technical debt on our side.
| as?: string | undefined; | ||
| async?: boolean | undefined; | ||
| autoComplete?: string | undefined; | ||
| autoComplete?: HTMLInputElement["autocomplete"]; |
There was a problem hiding this comment.
Tests are run without DOM typings since React is not tied to react-dom. It's unfortunate since these types should really live in @types/react-dom. You'd have to adjust types/react/global.d.ts so that it works with and without lib.dom.d.ts
typescript-bot
added
No Other Owners
|
@yanndinendal I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Nov 8th (in a week) if the issues aren't addressed. |
typescript-bot
added
the
Abandoned
|
@yanndinendal To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you! |
3 participants
See microsoft/TypeScript-DOM-lib-generator#1467
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.Hi, this is just a first draft because I'm pretty sure this is not the right way to do this but I would love some input to know if you think this would be feasible?
The issues I have are:
reactpackage, notreact-dom, do we don't have the'dom'` libProperty 'autocomplete' does not exist on type **'HTMLInputElement'.ts(2339)**react-dom, there are some overwrites, but not for Elements or Attributes; maybe this could be done that way?(tests pass in
react-domin TypeScript 5.2, but types are broken inreactitself in this branch).