Skip to content

[WIP] start supporting for TypeScript 1.6.0#5590

Merged
vvakame merged 59 commits intomasterfrom
tsc-1.6
Sep 3, 2015
Merged

[WIP] start supporting for TypeScript 1.6.0#5590
vvakame merged 59 commits intomasterfrom
tsc-1.6

Conversation

@vvakame
Copy link
Member

@vvakame vvakame commented Aug 28, 2015

@vvakame
Copy link
Member Author

vvakame commented Sep 3, 2015

I'm making some dirty fix.

$ ag "NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590"
angular2/angular2.d.ts
1370:    // NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590
1445:        // NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590

breeze/breeze-tests.ts
446:    /* NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590
764:    /* NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590
795:    /* NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590

devextreme/dx.devextreme.d.ts
3079:        // NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590

i18next/i18next.d.ts
22:    // NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590
76:    // NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590

react/react-addons-tests.ts
60:        // NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590

sequelize/sequelize-tests.ts
590:/* NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590
644:/* NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590
726:/* NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590
734:/* NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590
742:/* NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590
748:/* NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590
933:/* NOTE https://github.com/borisyankov/DefinitelyTyped/pull/5590

vvakame added a commit that referenced this pull request Sep 3, 2015
[WIP] start supporting for TypeScript 1.6.0
@vvakame vvakame merged commit 7c228c0 into master Sep 3, 2015
@vvakame vvakame deleted the tsc-1.6 branch September 3, 2015 14:17
@vvakame
Copy link
Member Author

vvakame commented Sep 3, 2015

great thanks for @DanielRosenwasser !

@DanielRosenwasser
Copy link
Member

You're very welcome @vvakame, but is there a way for me to continue testing disabled definitions? Or do I need to manually rename them?

@vvakame
Copy link
Member Author

vvakame commented Sep 3, 2015

do I need to manually rename them?

yes. PR is welcome. 👍 but disabled file is huge file... (3933f04

@vvakame
Copy link
Member Author

vvakame commented Sep 6, 2015

@FranPregernik what revision of js-data.d.ts did you use?

@FranPregernik
Copy link

Hi,

I think I used this exact one (e02dc63).

hope this helps also:

~/W/P/t/plm-mock git:master ❯❯❯ tsd --version
>> tsd 0.6.4

~/W/P/t/plm-mock git:master ❯❯❯ tsd query js-data --info
 - js-data / js-data    
   >> JSData 1.5.4     : github.com/js-data/js-data
    @ Stefan Steinhart : github.com/reppners

~/W/P/t/plm-mock git:master ❯❯❯ tsd query js-data --commit
 - js-data / js-data : e02dc6 : 2015-09-03 12:10

   4fb28c | 2015-02-25 21:45 | reppners   
    | + initial commit   

   143ee5 | 2015-02-26 08:53 | reppners   
    | + added tests   
    |    
    | + changed type definition to expose definitions as module and as globally defined namespace var   

   eec429 | 2015-03-02 20:27 | reppners   
    | + changing the JSData Promise type to interface   
    |    
    | + adding definitions object with usage example in tests for enabling custom type definitions of   
    | created resource definitions   

   5f2cc5 | 2015-03-04 08:09 | reppners   
    | + renaming module JSData_ to JSData since it is possible to declare var and module with the   
    | same name   

   a6cbfb | 2015-03-05 07:42 | reppners   
    | + changed promise declaration to own custom since it is not possible to reuse ES6 polyfill   
    | promise class declaration   

   e26a04 | 2015-03-06 07:23 | reppners   
    | + update of definitions to make use of union types   

   2ffc04 | 2015-08-21 23:27 | Daniel Rosenwasser @ DanielRosenwasser   
    | Fixed definitions for 'js-data'.   

   e02dc6 | 2015-09-03 12:10 | vvakame @ vvakame   
    | adhoc fix js-data/js-data.d.ts and js-data-http/js-data-http-tests.ts

@vvakame
Copy link
Member Author

vvakame commented Sep 8, 2015

@FranPregernik ah, i see.
https://github.com/borisyankov/DefinitelyTyped/blob/master/js-data/js-data.d.ts#L156
this is intersection types. this feature is new to 1.6.0-beta.
please use tsc 1.6.0-beta or older revision of js-data.d.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants