Skip to content

[@types/redux-orm] fix: static Model method issues - #37108

Merged
weswigham merged 1 commit into
DefinitelyTyped:masterfrom
tomasz-zablocki:types-redux-orm-fix-for-Model.create-and-Model.exists
Jul 24, 2019
Merged

[@types/redux-orm] fix: static Model method issues#37108
weswigham merged 1 commit into
DefinitelyTyped:masterfrom
tomasz-zablocki:types-redux-orm-fix-for-Model.create-and-Model.exists

Conversation

@tomasz-zablocki

@tomasz-zablocki tomasz-zablocki commented Jul 24, 2019

Copy link
Copy Markdown
Contributor
  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Summary of changes:

  • Remove Model.toRefArray and Model.toToModelArray methods, since they are not copied from QuerySet during initial setup.
  • correct Model.exists signature
  • fix for excessive Model.create argument requirements

@typescript-bot

typescript-bot commented Jul 24, 2019

Copy link
Copy Markdown
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

master #37108 diff
Batch compilation
Memory usage (MiB) 44.2 52.8 +19.5%
Type count 12257 9513 -22.4%
Assignability cache size 4814 3893 -19.1%
Subtype cache size 87 96 +10.3%
Identity cache size 152 125 -17.8%
Language service
Samples taken 826 900 +9.0%
Identifiers in tests 826 900 +9.0%
getCompletionsAtPosition
    Mean duration (ms) 182.7 148.8 -18.6%
    Median duration (ms) 273.4 178.5 -34.7% 🌟
    Mean CV 19.2% 21.1% +10.1%
    Worst duration (ms) 555.1 419.7 -24.4%
    Worst identifier ref authors
getQuickInfoAtPosition
    Mean duration (ms) 197.5 157.0 -20.5%
    Median duration (ms) 278.5 188.7 -32.2% 🌟
    Mean CV 17.0% 19.7% +16.2%
    Worst duration (ms) 464.5 372.8 -19.7%
    Worst identifier selector customProp

Wow, it looks like all the big movers moved in the right direction! Way to go! 🌟

If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot typescript-bot added Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels Jul 24, 2019
@typescript-bot

typescript-bot commented Jul 24, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@tomasz-zablocki Thank you for submitting this PR!

🔔 @keenondrums - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot

typescript-bot commented Jul 24, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@tomasz-zablocki

tomasz-zablocki commented Jul 24, 2019

Copy link
Copy Markdown
Contributor Author

@keenondrums thank you

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. and removed Awaiting reviewer feedback labels Jul 24, 2019
@weswigham
weswigham merged commit 2ccc2ff into DefinitelyTyped:master Jul 24, 2019
@tomasz-zablocki tomasz-zablocki mentioned this pull request Jul 25, 2019
Open
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
@tomasz-zablocki Konch Roman
[@types/redux-orm] fix: correct Model.exists signature and remove Mod…
febd264 
…el.toRefArray/Model.toModelArray functions (DefinitelyTyped#37108)
breeze9527 pushed a commit to breeze9527/DefinitelyTyped that referenced this pull request Jan 27, 2020
@tomasz-zablocki @breeze9527
[@types/redux-orm] fix: correct Model.exists signature and remove Mod…
b5da5b9 
…el.toRefArray/Model.toModelArray functions (DefinitelyTyped#37108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@fxlrnrpt fxlrnrpt fxlrnrpt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tomasz-zablocki @typescript-bot @fxlrnrpt @weswigham