Skip to content

Update tests in preparation for TS #32260#36728

Merged
ahejlsberg merged 1 commit intomasterfrom
prepare-for-ts32260
Jul 9, 2019
Merged

Update tests in preparation for TS #32260#36728
ahejlsberg merged 1 commit intomasterfrom
prepare-for-ts32260

Conversation

@ahejlsberg
Copy link
Collaborator

@ahejlsberg ahejlsberg commented Jul 8, 2019

Update tests in storage-helper and wordpress__hooks in preparation for microsoft/TypeScript#32260.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 8, 2019 •
edited
Loading

@ahejlsberg Thank you for submitting this PR!

🔔 @ajafff @dsifford - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 8, 2019

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

storage-helper/v1

Comparison details for storage-helper/v1 📊
master #36728 diff
Batch compilation
Memory usage (MiB) 35.9 35.6 -0.8%
Type count 2040 2039 0.0%
Assignability cache size 99 99 0.0%
Subtype cache size 0 0
Identity cache size 0 0
Language service
Samples taken 44 44 0.0%
Identifiers in tests 44 44 0.0%
getCompletionsAtPosition
    Mean duration (ms) 91.9 97.7 +6.4%
    Median duration (ms) 83.8 80.6 -3.9%
    Mean CV 28.9% 31.8% +9.8%
    Worst duration (ms) 130.6 130.3 -0.3%
    Worst identifier clear undefined
getQuickInfoAtPosition
    Mean duration (ms) 85.6 89.4 +4.4%
    Median duration (ms) 84.0 84.2 +0.2%
    Mean CV 25.7% 25.7% 0.0%
    Worst duration (ms) 101.3 115.7 +14.3%
    Worst identifier removeItem storageHelper

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.

wordpress__hooks/v2

Comparison details for wordpress__hooks/v2 📊
master #36728 diff
Batch compilation
Memory usage (MiB) 36.7 36.5 -0.4%
Type count 2118 2119 0.0%
Assignability cache size 113 113 0.0%
Subtype cache size 0 0
Identity cache size 0 0
Language service
Samples taken 88 88 0.0%
Identifiers in tests 88 88 0.0%
getCompletionsAtPosition
    Mean duration (ms) 86.7 93.4 +7.7%
    Median duration (ms) 78.9 78.2 -0.8%
    Mean CV 26.3% 28.6% +8.7%
    Worst duration (ms) 135.8 144.9 +6.7%
    Worst identifier firstFilter firstFilter
getQuickInfoAtPosition
    Mean duration (ms) 81.2 86.1 +6.1%
    Median duration (ms) 77.5 76.8 -0.8%
    Mean CV 26.6% 26.3% -1.0%
    Worst duration (ms) 119.5 134.5 +12.6%
    Worst identifier bar hooks
System information
Node version v10.16.0 v10.16.0
CPU count 2 2
CPU speed 2.294 GHz 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64 x64
Memory 6.8 GiB 6.8 GiB
Platform linux linux
Release 4.15.0-1047-azure 4.15.0-1047-azure

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.

If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@ahejlsberg ahejlsberg requested a review from RyanCavanaugh July 8, 2019 18:31
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Jul 9, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 9, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@ahejlsberg ahejlsberg merged commit a666fed into master Jul 9, 2019
@ahejlsberg ahejlsberg deleted the prepare-for-ts32260 branch July 9, 2019 17:30
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
@ahejlsberg
Ensure tests produce same results before and after TS DefinitelyTyped…
740eae9 
…#32260 (DefinitelyTyped#36728)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

1 more reviewer

@dsifford dsifford dsifford approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahejlsberg @typescript-bot @dsifford