#6930: Updates Dojox Charting definition module exports#20654
Merged
6 commits merged intoDefinitelyTyped:masterfrom Oct 17, 2017
dgwaldo:master
Merged
#6930: Updates Dojox Charting definition module exports#206546 commits merged intoDefinitelyTyped:masterfrom dgwaldo:master
6 commits merged intoDefinitelyTyped:masterfrom
dgwaldo:master
Conversation
Contributor
|
@dgwaldo Please fix the failures indicated in the Travis CI log. |
Seems that the CI build fails unless this compiler flag is present, but doesn't seem to be representative of the current typescript options. The instructions say to run tsc, however it seems the flags may have changed between versions. The Travis CI output does not report the tsc version number being used.
This reverts commit aba384b.
This reverts commit 41cda05.
Contributor
Author
|
Ok it appears I'm wrong, apparently this is a flag that has been recently added to TS. Also found the commit where this flag was added to all of the libraries in definitely typed. A wee tad confusing. |
ghost
merged commit
Contributor
Author
|
@RyanCavanaugh, @Andy-MS wondering if the npm build bot is working? |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the file based on the fact that using newer versions of typescript the modules where not visible.
Here is a link to the currently open issue.
Upon running tsc, I had to modify the tsconfig.json because strictFunctionTypes does not seem to be a valid compiler option anymore.
https://www.typescriptlang.org/docs/handbook/modules.html