Skip to content

kefir: Use never instead of void for Observable type arguments#17248

Merged
1 commit merged intomasterfrom
kefir-never
Jun 16, 2017
Merged

kefir: Use never instead of void for Observable type arguments#17248
1 commit merged intomasterfrom
kefir-never

Conversation

@ghost
Copy link

@ghost ghost commented Jun 16, 2017

This is a more accurate way to convey that, for example, a stream never errors.
It fixes new compile errors in typescript@next due to convariance checking (microsoft/TypeScript#15104).

@dt-bot
Copy link
Member

dt-bot commented Jun 16, 2017

types/kefir/index.d.ts

to author (@AyaMorisawa). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@ghost ghost merged commit aa3a920 into master Jun 16, 2017
@ghost ghost deleted the kefir-never branch June 16, 2017 15:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants