Conversation
j-chmielewski
force-pushed
the
proxy-events
branch
from
4a1f05a to
93d235c
Compare
wojcik91
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates proxy to treat the retrieval of the client IP address as mandatory rather than optional.
Previously, the server allowed for the client IP to be omitted, under the assumption that it may not always be retrievable. However, in practice, the inability to obtain the client IP can only occur in case of misconfiguration. Treating the IP as optional was masking these configuration issues instead of surfacing them appropriately.
By making the client IP mandatory we align the protobuf data structure constraints with the actual expectations and ensure that upstream systems relying on this metadata receive consistent and complete information.