Skip to content

Add llvm-16 support - #2

Merged
prajwal-deepsource merged 1 commit into
masterfrom
llvmbase16
Jun 16, 2023
Merged

Add llvm-16 support#2
prajwal-deepsource merged 1 commit into
masterfrom
llvmbase16

Conversation

@deepak-deepsource

Copy link
Copy Markdown
Contributor

This PR upgrades the LLVM version from fifteen to sixteen. It also create a missing symlink in llvm lib.

PS: When LLVM apt sort the issue of missing symlink we can remove the ln -s command.

@prajwal-deepsource prajwal-deepsource left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Considering the complexity of the build process for this repo and marvin-cxx, you might want to look into using a Nix flake for setting up the environment instead. While the Dockerfile will be the same for our cloud builds, having the ability to get your local setup running with just nix develop will make it a lot easier for others to hit the ground running if they decide to contribute to the analyzers!

@deepak-deepsource

Copy link
Copy Markdown
Contributor Author

LGTM. Considering the complexity of the build process for this repo and marvin-cxx, you might want to look into using a Nix flake for setting up the environment instead. While the Dockerfile will be the same for our cloud builds, having the ability to get your local setup running with just nix develop will make it a lot easier for others to hit the ground running if they decide to contribute to the analyzers!

For now local setup on Mac OS is as simple as the running the following commands

$ brew install llvm@16 && tack --build lta

where tack is Python script to invoke cmake after setting some envs.

I am yet to get a chance to use Nix but do they support installing latest version of llvm?

@prajwal-deepsource

prajwal-deepsource commented Jun 16, 2023

Copy link
Copy Markdown

Yes, they do have llvm_16 on the Nix repository. But if the current script works, then we're good

@prajwal-deepsource
prajwal-deepsource merged commit 867e5b9 into master Jun 16, 2023
@prajwal-deepsource
prajwal-deepsource deleted the llvmbase16 branch June 16, 2023 05:20
swarnim-deepsource added a commit that referenced this pull request Jun 16, 2023
srijan-deepsource added a commit that referenced this pull request Jun 16, 2023
This reverts commit 867e5b9.

Co-authored-by: Swarnim Arun <99165284+swarnim-deepsource@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants