Make the format of the PDB flexible so that we can read ZDOCK file#81
Closed
NicoRenaud wants to merge 6 commits into
Closed
Make the format of the PDB flexible so that we can read ZDOCK file#81NicoRenaud wants to merge 6 commits into
NicoRenaud wants to merge 6 commits into
Conversation
Member
Author
|
We can now read zdock files (and most likely other format that complies with the PDB format up to the xyz coordinate). |
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if that's something we really want to do, but since pdb files are not all the time in the exact format we would like them to be, this PR tries to make pdb2sql a bit more flexible so that we can read more pdb files. See #74
There is now a
flexible_formatarg in the constructor ofpdb2sqlthat if turned totrueallow to only read the data up to the xyz coordinates. The default value isfalseand will therefore crash when trying to open a non ideal pdb files