Skip to content

Fixes to avoid data loss #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deruyter92 wants to merge 7 commits into from
Open

Fixes to avoid data loss #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9c07a8b
fix: save processor data before destroying it when stopping inference…
deruyter92 Jul 23, 2026
50048b5
revert 3eba29f85b7e187c37bb791307c4a1b0e94caa27
deruyter92 Jul 23, 2026
0d59b32
fix dlc_processor: clean up custom processor during DLC shutdown
deruyter92 Jul 23, 2026
9571c2a
warn: confirm before stopping inference while recording
deruyter92 Jul 23, 2026
bf8f402
Update dlclivegui/gui/main_window.py
deruyter92 Aug 10, 2026
8ad9d6f
Update dlclivegui/gui/main_window.py
deruyter92 Aug 10, 2026
c9264f3
Fix message when stopping inference while recording
C-Achard Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions dlclivegui/gui/main_window.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2482,6 +2482,18 @@ def _start_inference(self) -> None:
self._update_dlc_controls_enabled()

def _stop_inference(self, show_message: bool = True) -> None:
if self._rec_manager.is_active:
answer = QMessageBox.question(
self,
"Stop inference while recording?",
"This will stop the currently running DLC-live custom processor, if any.\n"
"File saving will not be handled via the standard 'recording stopped' event hooks."
"The processor might still save data now, but it will not be paired with the recording.\n\n"
"Stop inference anyway?",
)
if answer != QMessageBox.Yes:
return

was_active = self._dlc_active
self._dlc_active = False
self._dlc_initialized = False
Expand Down
8 changes: 4 additions & 4 deletions dlclivegui/services/dlc_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,10 +282,10 @@ def shutdown(self) -> None:
with self._lifecycle_lock:
self._pending_reset = True
self._pending_processor_cleanup = True
logger.warning(
"Shutdown requested but worker thread is still alive; DLCLive instance may not be fully released."
)
return
logger.warning(
"Shutdown requested but worker thread is still alive; DLCLive instance may not be fully released."
)
return

self._cleanup_processor()
Comment thread
deruyter92 marked this conversation as resolved.
self._dlc = None
Expand Down