GUI fixes (config editor + reload timer) - #3441
Draft
deruyter92 wants to merge 3 commits into
Draft
Conversation
DictViewer passes the config path straight to QLabel, which only accepts str. Since the pathlib migration ConfigEditor hands it a Path, so opening "Edit config.yaml" raises TypeError. Reproduced on PySide6 6.7.3 and 6.9.3; it went unnoticed because the GUI tests are skipped where PySide6 is absent.
The deferred reload timer was duplicated in ManageProject and AnalyzeVideos, and each of the five tabs opened ConfigEditor slightly differently. They now share DefaultTab._open_config_editor, which keeps the dialog referenced and parents it to the main window. That fixes two latent bugs in the pose_cfg / inference_cfg tabs, where the dialog was a bare local: nothing kept it alive after the method returned, and without a parent ConfigEditor skipped its screen-relative sizing. Only the project config asks for a reload, since rebuilding the tabs is wrong for the other files.
Cover the dialog outliving the call that opened it, the single deferred reload after saving the project config, the absence of a reload for any other config, and the no-op when no project is loaded.
C-Achard
added
GUI
C-Achard
approved these changes
Aug 13, 2026
C-Achard
left a comment
C-Achard
left a comment
Collaborator
There was a problem hiding this comment.
Great changes, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix pathlib coercion & centralize editor opening
DefaultTab._open_config_editor()andopen_project_config_editor().Deduplicate deferred reload timer
ManageProjectandAnalyzeVideoseach owned an identical single-shotQTimerto deferreload_project_configuntilafter the config editor closed. That logic now lives on
DefaultTaband is connected only when editing the projectconfig.yaml(reload_project=True). Editing pose/inference configs still does not schedule a reload.