Fix uncaught NetworkX exceptions in TrackletStitcher.stitch() fallback - #3418
Open
deruyter92 wants to merge 1 commit into
Open
Fix uncaught NetworkX exceptions in TrackletStitcher.stitch() fallback#3418deruyter92 wants to merge 1 commit into
deruyter92 wants to merge 1 commit into
Conversation
When the minimum-cost flow problem is infeasible, the "black magic" fallback path in stitch() calls `node_disjoint_paths` and a second `capacity_scaling`, both of which could raise uncaught exceptions (`NetworkXNoPath` and `NetworkXUnfeasible`), preventing `self.paths` from being set and causing the finally block to re-raise as a fatal ValueError. This left users with only the raw pickle file and no .h5/.csv output after a multi-hour detection run, with no actionable error message. Fix: wrap both calls in try/except, warn, and continue with any partial paths already found — matching the existing design intent where line 731 already warned when `len(paths) != n_tracks`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TrackletStitcher.stitch()crashes withValueError: Could not reconstruct N trackswhen the fallback ("black magic") path encounters infeasible flow problems, discarding all stitching work and leaving users with no.h5/.csvoutput after a completed detection run.networkxexceptions inside theexcept NetworkXUnfeasiblehandler, which preventself.pathsfrom ever being set.Reported by: image.sc forum — user analyzing 4 visually similar mice in 1-hour videos at 60fps.
Fix
Wrap both exception sources in
try/except(matching the existing design intent):node_disjoint_paths→ catchNetworkXNoPath, warn, continue with any paths already found.capacity_scaling→ catchNetworkXUnfeasible, warn, keep existing paths.