GUI: use importlib.resources instead of manual path construction - #3385
Closed
deruyter92 wants to merge 3 commits into
Closed
GUI: use importlib.resources instead of manual path construction#3385deruyter92 wants to merge 3 commits into
deruyter92 wants to merge 3 commits into
Conversation
Collaborator
Author
|
ok nevermind, I forgot this was already taken care of in #3370, closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #3349 and is related to #3350. Together these PRs enforce more robust path resolution across the codebase.
Summary
This PR replaces all manual path constructions in the GUI (for accessing the assets, like the logo, etc) with
importlib.resources. This loads correctly regardless of the process working directory, editable installs, or where the user launched the GUI from and should be the canonical way to load GUI assets. It was already implemented in some places, but now made more consistent.