Clean dlc_torch.analyze_videos()
#3079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I pulled this and analyzed some videos across a bunch of DLC projects. Works great, thanks for the simplification. LGTM. |
AlexEMG
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes additional snapshot validation and fallback logic that had been introduced in #3036.
These checks are redundant, since snapshot resolution and validation are already fully handled by
utils.pyand theSnapshotclass. Duplicating this logic insidedlc_torch.analyze_videos()made the method unnecessarily long and difficult to follow.analyze_videos()is a high-level orchestration method (creating inference runners, loading models, running inference, tracking, etc.), and is not the right place for such low-level checks. If changes of this kind are needed, they should be implemented inutils.py, in theSnapshotclass, or in theTorchSnapshotManagerclass, in order to respect the modularity principle and keep responsibilities clearly separated.This cleanup improves readability and maintainability of the code, while keeping snapshot handling logic centralized where it belongs.