create_labeled_video fails with single animal TensorFlow models#2826
Merged
n-poulsen merged 1 commit intopytorch_dlcfrom Jan 7, 2025
Merged
create_labeled_video fails with single animal TensorFlow models#2826n-poulsen merged 1 commit intopytorch_dlcfrom
create_labeled_video fails with single animal TensorFlow models#2826n-poulsen merged 1 commit intopytorch_dlcfrom
Conversation
2 tasks
maximpavliv
approved these changes
Jan 7, 2025
Contributor
maximpavliv
left a comment
maximpavliv
left a comment
There was a problem hiding this comment.
Great, thank you @n-poulsen ! I think we can merge this
|
Not fixed as far as I can tell, despite a successful pip upgrade. #2796 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in this comment from issue 2796,
create_labeled_videofails to create a labeled video for TensorFlow single-animal projects, as it could not find the "full_data" file which is not created for such models. The content of the file was used to plot bounding boxes in the video for top-down PyTorch models.This pull request fixes the issue by catching the
FileNotFoundErrorwhen the file is not present. The functional testexamples/testscript.pyis updated to check that the videos have all videos have been created successfully. This updated test fails with the when the bug is in the code, and succeeds with the fix above.